[Bug] Pinned (remember last input) status is carried over when switching between note types in editor

[jgscherber]

Reproduction Steps

1. Create new card where note has an unpinned field
2. Switch to another note type with a pinned field
3. Switch back

See video and the 2nd field's pinned status

https://github.com/ankidroid/Anki-Android/assets/6207661/a2a8ac88-df4b-48ff-a1d3-31bb89c3995d

Expected Result

The fields aren't pinned

Actual Result

The field is pinned after switching bacm

Debug info

Refer to the support page if you are unsure where to get the "debug info".

AnkiDroid Version = 2.16.5 (953b9bd879269910ee962b520da9705336d8bc2d)

Android Version = 13

ProductFlavor = play

Manufacturer = samsung

Model = SM-G981U1

Hardware = qcom

Webview User Agent = Mozilla/5.0 (Linux; Android 13; SM-G981U1 Build/TP1A.220624.014; wv) AppleWebKit/537.36 (KHTML, like Gecko) Version/4.0 Chrome/120.0.6099.43 Mobile Safari/537.36

ACRA UUID = 03434583-cd6c-4869-8ed2-d8e7712382df

New schema = false

Scheduler = std2

Crash Reports Enabled = true

DatabaseV2 Enabled = true

Research

Enter an [x] character to confirm the points below:

• [x] I have read the support page and am reporting a bug or enhancement request specific to AnkiDroid
• [x] I have checked the manual and the FAQ and could not find a solution to my issue
• [x] I have searched for similar existing issues here and on the user forum
• [ ] (Optional) I have confirmed the issue is not resolved in the latest alpha release (instructions)

[SanjaySargam]

I want to work on this issue.

From my understanding, pinned fields are specific to each note type. When we change the note type, it pins the previous note type pinned field and the current note type pinned field. The expected behavior is only pin current note type pinned field

Correct me if I'm wrong

[david-allison]

Sounds correct

[github-actions[bot]]

Hello 👋, this issue has been opened for more than 3 months with no activity on it. If the issue is still here, please keep in mind that we need community support and help to fix it! Just comment something like still searching for solutions and if you found one, please open a pull request! You have 7 days until this gets closed automatically