ankidroid / Anki-Android

AnkiDroid: Anki flashcards on Android. Your secret trick to achieve superhuman information retention.
GNU General Public License v3.0
8.59k stars 2.22k forks source link

[BUG]: "Hide the system bars" also hides the top ankidroid bar #15762

Open Licorioo opened 7 months ago

Licorioo commented 7 months ago

Checked for duplicates?

What are the steps to reproduce this bug?

  1. Settings > Appearance > Fullscreen mode > Hide the system bars
  2. Start learning

Expected behaviour

Screenshot_20240303-214006_AnkiDroid

Actual behaviour

Screenshot_20240303-215109_Files by Google

Debug info

AnkiDroid Version = 2.17.3 (ca4cb3c2802bcb17e73b051e7e42308993513717)

Backend Version = 0.1.34-anki23.12.1 (23.12.1 1a1d4d5419c6b57ef3baf99c9d2d9cf85d36ae0a)

Android Version = 13 (SDK 33)

ProductFlavor = full

Manufacturer = samsung

Model = SM-G975F

Hardware = exynos9820

Webview User Agent = Mozilla/5.0 (Linux; Android 13; SM-G975F Build/TQ3A.230805.001; wv) AppleWebKit/537.36 (KHTML, like Gecko) Version/4.0 Chrome/121.0.6167.180 Mobile Safari/537.36

ACRA UUID = 12705547-5e86-47fa-8617-d314f0d9b6c9

Crash Reports Enabled = false

(Optional) Anything else you want to share?

When I saw "Hide the system bars" I expected that it would hide only this:

system-bars-status-bar-light-dark-theme

The laziest way to solve the problem would be to simply change the name from "Hide the system bars" to "Hide the top bars"

A better solution would be to give the user the option of what exactly they want to hide

Research

welcome[bot] commented 7 months ago

Hello! 👋 Thanks for logging this issue. Please remember we are all volunteers here, so some patience may be required before we can get to the issue. Also remember that the fastest way to get resolution on an issue is to propose a change directly, https://github.com/ankidroid/Anki-Android/wiki/Contributing

CyberButton commented 7 months ago

I can look into it

CyberButton commented 7 months ago

Actually, I think I'll wait for a response from maintainers on this, cuz it sounds like a some kind of feature request

neeldoshii commented 6 months ago

Maintainers Note : Reproduced

This does needs to be addressed. In both screenshot there seems to be some kind of hiding system bar bug here as system bar should have been in blue color for light mode but its showing in black in image below.

Image 1 Image 2
screenshot screenshot

Also do you @CyberButton wish to take on this issue?

CyberButton commented 6 months ago

Maintainers Note : Reproduced

This does needs to be addressed. In both screenshot there seems to be some kind of hiding system bar bug here as system bar should have been in blue color for light mode but its showing in black in image below.

Image 1 Image 2 screenshot screenshot Also do you @CyberButton wish to take on this issue?

No sorry I am already working on different issue

neeldoshii commented 6 months ago

I will take it up.

github-actions[bot] commented 3 months ago

Hello 👋, this issue has been opened for more than 3 months with no activity on it. If the issue is still here, please keep in mind that we need community support and help to fix it! Just comment something like still searching for solutions and if you found one, please open a pull request! You have 7 days until this gets closed automatically