ankidroid / Anki-Android

AnkiDroid: Anki flashcards on Android. Your secret trick to achieve superhuman information retention.
GNU General Public License v3.0
8.41k stars 2.19k forks source link

Productionise WebView >= 77 check #15855

Closed david-allison closed 3 months ago

david-allison commented 6 months ago

It'd be worth having the dev-only check introduced in https://github.com/ankidroid/Anki-Android/issues/14702 also explain to regular users how to upgrade.

Android 6 supports >= WebView 77, so a user should be able to upgrade

Originally posted by @david-allison in https://github.com/ankidroid/Anki-Android/issues/15847#issuecomment-1988370221


EDIT: Please also include a guide to fix the WebView if the package is incorrect: https://github.com/ankidroid/Anki-Android/issues/15847#issuecomment-1988304056

aayush-tripathi commented 6 months ago

Hey! Can I work on this?

aayush-tripathi commented 6 months ago

Hello again. I have been working on this issue and have come up with the following Dialog Box containing a link to the Google Play Store.

Screenshot 2024-03-13 024444

I want to confirm if I have approached this correctly. Thanks!

david-allison commented 6 months ago

Looks like a good UI! We'll need to work on the strings, but that can be done in the PR

https://github.com/ankidroid/Anki-Android/blob/818a8134d16d6455993bbf80bd66900db445cd89/AnkiDroid/src/main/java/com/ichi2/utils/WebViewUtils.kt#L39-L40

neeldoshii commented 4 months ago

Can i get assigned to this as the above PR is saying Needs a new dev?

david-allison commented 4 months ago

@neeldoshii done, please use the PR as it's REALLY close + please be sure you're using git cherry pick to give them credit