search

ankidroid / Anki-Android

AnkiDroid: Anki flashcards on Android. Your secret trick to achieve superhuman information retention.
GNU General Public License v3.0
8.5k stars 2.21k forks source link

[Enhancement] Crop tool for image occlusion #15864

Open Devaprasad-reddy opened 6 months ago

Devaprasad-reddy commented 6 months ago

Is your feature request related to a problem? Please describe. I want to crop out giveaways in an IO card but to do it I had to delete the card and crop it in my phone and upload as a new card, which also makes me loose the progress of that card

Describe the solution you'd like A crop tool in the IO editing interface would be nice to have

Describe alternatives you've considered Creating a New card again.

Additional context Also two finger pan would be nice instead of 4 buttons to zoom in and out.

awanishyadav967 commented 6 months ago

I would like to work on this @david-allison

david-allison commented 6 months ago

Thanks! See the following for how we currently open a crop tool:

https://github.com/ankidroid/Anki-Android/blob/a2c16051a4891292e6c571d5f1fac7910311997b/AnkiDroid/src/main/java/com/ichi2/anki/multimediacard/fields/BasicImageFieldController.kt#L98

criticalAY commented 6 months ago

Just in case #15029 get merged before this then we just need to call the method

awanishyadav967 commented 6 months ago

Hi @david-allison I created the new PR ,Please Review it.

david-allison commented 6 months ago

@awanishyadav967 In future, no need to ping me on GitHub, I already get notifications for new Pull Requests, and Discord can be used for 'you should look at this' pings if it's not reviewed in a sufficient amount of time

github-actions[bot] commented 3 months ago

Hello 👋, this issue has been opened for more than 3 months with no activity on it. If the issue is still here, please keep in mind that we need community support and help to fix it! Just comment something like still searching for solutions and if you found one, please open a pull request! You have 7 days until this gets closed automatically

Devaprasad-reddy commented 3 months ago

Is this out..?