feat: initial 'Remove account' implementation

david-allison commented 2 weeks ago

Purpose / Description

Google require that we more prominently display 'Delete Account'

Fixes

Some of #16256

[x] the path for requesting deletion is not prominently displayed (for example a little process diagram of "1) access this page 2) log in to the account 3) click delete account link" 4) confirm ?
- [x] note that the destination URL of "remove-account" is not remembered for redirect after login if not authenticated which would be nice to have. So currently steps are "click remove-account link", "log in", "click account", "click remove account", "confirm", account is deleted...
[ ] ⚠️ the name doesn't match - we are "AnkiDroid Flashcards" on Play Store listing but that is not listed on the page at all. This is difficult. We need to have that name on the Play Store, but the account is an "AnkiWeb" account based on the webpage. Is there a way to include some information on the deletion page that this account is used by all compatible Anki ecosystem apps including Anki Mobile, Anki Desktop, and AnkiDroid Flashcards?
[x] Privacy Policy link

Approach

A 'remove account' button opens AnkiWeb
A user must log in to AnkiWeb if they did not already do so in 'Shared Decks'
- We perform an internal redirect back to the 'remove account' functionality
A user must enter their password
A user must type 'remove'

How Has This Been Tested?

API 33 emulator

with non-validated account
with validated account

Learning (optional, can help others)

Google 🤷‍♂️ ... happily let copycats into the store, still make us jump through hoops

Checklist

[x] You have a descriptive commit message with a short title (first line, max 50 chars).
[x] You have commented your code, particularly in hard-to-understand areas
[x] You have performed a self-review of your own code
[ ] UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
[ ] UI Changes: You have tested your change using the Google Accessibility Scanner

github-actions[bot] commented 2 weeks ago

Message to maintainers, this PR contains strings changes.

Before merging this PR, it is best to run the "Sync Translations" GitHub action, then make and merge a PR from the i18n_sync branch to get translations cleaned out.
Then merge this PR, and immediately do another translation PR so the huge change made by this PR's key changes are all by themselves.

Read more about updating strings on the wiki,

mikehardy commented 2 weeks ago

As long as the copycat also respects user privacy and we are not guarding intellectual property in the "Anki" name copycats are fine 🤷 - orthogonal issues

david-allison commented 2 weeks ago

Nits picked, Privacy policy added

david-allison commented 2 weeks ago

We have full control over the page as it's in a WebView

But we also need this if the user clicks the delete account link from the Play Store, which isn't under our control

mikehardy commented 2 weeks ago

Just trying to push strings through past flakiness... #16267

github-actions[bot] commented 2 weeks ago

Maintainers: Please Sync Translations to produce a commit with only the automated changes from this PR.

Read more about updating strings on the wiki,

dae commented 2 weeks ago

Ask Damien very nicely to put a mention about the clients currently using the account data(Anki, Anki Mobile and AnkiDroid Flashcards)?

I can do this as a last resort, but I think it's unreasonable for a third-party service to have to do this - have you tried pointing out to them that the service is not under your control? I'm sure Twitter/X's account removal page doesn't list all the third-party clients that access it for example.

snowtimeglass commented 1 week ago

As a desirable approach on the client (AnkiDroid) side, I suppose that it would be better to use AnkiWeb logo for the "AnkiWeb account" screen rather than AnkiDroid logo (only), to be less misleading.

In case that an app has a screen for connecting to Twitter/X, it is natural to use Twitter/X logo in the screen, rather than the logo of the app itself (only).

I would think the same is true for the screen for connecting to AnkiWeb.

snowtimeglass commented 1 week ago

it would be better to use AnkiWeb logo for the "AnkiWeb account" screen rather than AnkiDroid logo (only), to be less misleading.

That is, for example,

Simply replacing the logo
Displaying the two logos to visualize the independence of the app (AnkiDroid) and the external service (AnkiWeb) from each other.

[Reference]

[image]

(Anyway, the current logo on the screen may be a bit too big.)

david-allison commented 1 week ago

As a desirable approach on the client (AnkiDroid) side, I suppose that it would be better to use AnkiWeb logo for the "AnkiWeb account" screen rather than AnkiDroid logo (only), to be less misleading.

In case that an app has a screen for connecting to Twitter/X, it is natural to use Twitter/X logo in the screen, rather than the logo of the app itself (only).

I think the same would be true for the screen for connecting to AnkiWeb.

Could you move these comments to a separate issue? I agree and they should be discussed, but they'll be lost if added to a closed PR

ankidroid / Anki-Android