ankidroid / Anki-Android

AnkiDroid: Anki flashcards on Android. Your secret trick to achieve superhuman information retention.
GNU General Public License v3.0
7.94k stars 2.16k forks source link

Unicode character instead of three dots for ellipsis #16270

Closed Aditya13s closed 2 weeks ago

Aditya13s commented 2 weeks ago

Purpose / Description

This PR addresses a lint improvement in which ... is replaced with unicode ….

Fixes

Approach

Added a function in TranslationTypo.visitElement() to check if the text contains ... or not.

How Has This Been Tested?

I test by running lint test and it shows `Error: should use unicode '…' instead of three dots for ellipsis [TranslationTypo from com.ichi2.anki:lint-rules]

Processing...` ## Checklist - [x] You have a descriptive commit message with a short title (first line, max 50 chars). - [x] You have commented your code, particularly in hard-to-understand areas - [x] You have performed a self-review of your own code - [x] UI changes: include screenshots of all affected screens (in particular showing any new or changed strings) - [ ] UI Changes: You have tested your change using the [Google Accessibility Scanner](https://play.google.com/store/apps/details?id=com.google.android.apps.accessibility.auditor)
lukstbit commented 2 weeks ago

Requires manual work from reviewers to fix current translations and the reference strings that get uploaded to crowdin.

mikehardy commented 2 weeks ago

Interesting on the manual work comment:

david-allison commented 2 weeks ago

Don't change the keys, very limited value

The initial aim of the issue was to catch bad translations

This has morphed into also catching bad strings in /values

There's a different approach in the two:

The next step is to get a map from key to bad [string/translation]. I'll take this on

david-allison commented 2 weeks ago

Strings

Translations

david-allison commented 2 weeks ago

My fault! Sorry about the close

I'm running a translation sync.

I've fixed a number of the above translations and all the strings

- 383 errors, 0 warnings
+ 79 errors
/Users/davidallison/StudioProjects/Anki-Android/AnkiDroid/src/main/res/values-tt/01-core.xml:127: Error: should use unicode '…' instead of three dots for ellipsis [TranslationTypo from com.ichi2.anki:lint-rules] Фильтрлы колода үзгәртелә... ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /Users/davidallison/StudioProjects/Anki-Android/AnkiDroid/src/main/res/values-af/01-core.xml:130: Error: should use unicode '…' instead of three dots for ellipsis [TranslationTypo from com.ichi2.anki:lint-rules] Herbouing van gefilterde pak... ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /Users/davidallison/StudioProjects/Anki-Android/AnkiDroid/src/main/res/values-et/01-core.xml:130: Error: should use unicode '…' instead of three dots for ellipsis [TranslationTypo from com.ichi2.anki:lint-rules] Taastan filtritud kaardipakki... ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /Users/davidallison/StudioProjects/Anki-Android/AnkiDroid/src/main/res/values-mr/01-core.xml:130: Error: should use unicode '…' instead of three dots for ellipsis [TranslationTypo from com.ichi2.anki:lint-rules] फिल्टर केलेले डेक पुन्हा तयार करीत आहे ... ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /Users/davidallison/StudioProjects/Anki-Android/AnkiDroid/src/main/res/values-sv/01-core.xml:130: Error: should use unicode '…' instead of three dots for ellipsis [TranslationTypo from com.ichi2.anki:lint-rules] Bygger om filtrerad kortlek... ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /Users/davidallison/StudioProjects/Anki-Android/AnkiDroid/src/main/res/values-tt/01-core.xml:131: Error: should use unicode '…' instead of three dots for ellipsis [TranslationTypo from com.ichi2.anki:lint-rules] Фильтрлы колода бушатыла... ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /Users/davidallison/StudioProjects/Anki-Android/AnkiDroid/src/main/res/values-af/01-core.xml:134: Error: should use unicode '…' instead of three dots for ellipsis [TranslationTypo from com.ichi2.anki:lint-rules] Besig om die gefilterde pak leeg te maak... ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /Users/davidallison/StudioProjects/Anki-Android/AnkiDroid/src/main/res/values-da/01-core.xml:134: Error: should use unicode '…' instead of three dots for ellipsis [TranslationTypo from com.ichi2.anki:lint-rules] Tømmer filtreret stak... ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /Users/davidallison/StudioProjects/Anki-Android/AnkiDroid/src/main/res/values-et/01-core.xml:134: Error: should use unicode '…' instead of three dots for ellipsis [TranslationTypo from com.ichi2.anki:lint-rules] Tühjendan filtritud kaardipakki... ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /Users/davidallison/StudioProjects/Anki-Android/AnkiDroid/src/main/res/values-sv/01-core.xml:134: Error: should use unicode '…' instead of three dots for ellipsis [TranslationTypo from com.ichi2.anki:lint-rules] Tömmer filtrerad kortlek... ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /Users/davidallison/StudioProjects/Anki-Android/AnkiDroid/src/main/res/values-te/01-core.xml:134: Error: should use unicode '…' instead of three dots for ellipsis [TranslationTypo from com.ichi2.anki:lint-rules] ఫిల్టర్ చేసిన డెక్‌ను ఖాళీ చేస్తోంది... ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /Users/davidallison/StudioProjects/Anki-Android/AnkiDroid/src/main/res/values-tt/01-core.xml:146: Error: should use unicode '…' instead of three dots for ellipsis [TranslationTypo from com.ichi2.anki:lint-rules] Кире кагу...\nБу бераз вакыт алырга мөмкин ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /Users/davidallison/StudioProjects/Anki-Android/AnkiDroid/src/main/res/values-bn/01-core.xml:149: Error: should use unicode '…' instead of three dots for ellipsis [TranslationTypo from com.ichi2.anki:lint-rules] Cancelling...\nThis কিছু সময় লাগতে পারে। ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /Users/davidallison/StudioProjects/Anki-Android/AnkiDroid/src/main/res/values-ca/01-core.xml:149: Error: should use unicode '…' instead of three dots for ellipsis [TranslationTypo from com.ichi2.anki:lint-rules] S\'està cancel·lant...\nAixò pot trigar una estona. ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /Users/davidallison/StudioProjects/Anki-Android/AnkiDroid/src/main/res/values-fil/01-core.xml:149: Error: should use unicode '…' instead of three dots for ellipsis [TranslationTypo from com.ichi2.anki:lint-rules] Kinakansela...\nIto ay maaaring matagalan. ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /Users/davidallison/StudioProjects/Anki-Android/AnkiDroid/src/main/res/values-fr/01-core.xml:149: Error: should use unicode '…' instead of three dots for ellipsis [TranslationTypo from com.ichi2.anki:lint-rules] Annulation...\nCeci peut prendre un certain temps. ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /Users/davidallison/StudioProjects/Anki-Android/AnkiDroid/src/main/res/values-it/01-core.xml:149: Error: should use unicode '…' instead of three dots for ellipsis [TranslationTypo from com.ichi2.anki:lint-rules] Annullo...\nPotrebbe richiedere del tempo. ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /Users/davidallison/StudioProjects/Anki-Android/AnkiDroid/src/main/res/values-mr/01-core.xml:149: Error: should use unicode '…' instead of three dots for ellipsis [TranslationTypo from com.ichi2.anki:lint-rules] रद्द करीत आहे... \n यास काही वेळ लागू शकेल. ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /Users/davidallison/StudioProjects/Anki-Android/AnkiDroid/src/main/res/values-pt-rBR/01-core.xml:149: Error: should use unicode '…' instead of three dots for ellipsis [TranslationTypo from com.ichi2.anki:lint-rules] Cancelando...\nPode levar algum tempo. ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /Users/davidallison/StudioProjects/Anki-Android/AnkiDroid/src/main/res/values-te/01-core.xml:149: Error: should use unicode '…' instead of three dots for ellipsis [TranslationTypo from com.ichi2.anki:lint-rules] రద్దు...\nదీనికి కొంత సమయం పట్టవచ్చు. ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /Users/davidallison/StudioProjects/Anki-Android/AnkiDroid/src/main/res/values-ti/01-core.xml:149: Error: should use unicode '…' instead of three dots for ellipsis [TranslationTypo from com.ichi2.anki:lint-rules] ይቋረጽ......\n ውሑድ ግዜ ክወስድ ይኽእል ኢዩ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /Users/davidallison/StudioProjects/Anki-Android/AnkiDroid/src/main/res/values-uz/01-core.xml:149: Error: should use unicode '…' instead of three dots for ellipsis [TranslationTypo from com.ichi2.anki:lint-rules] Bekor qilinyapti...\n Bu biroz vaqt olishi mumkin ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /Users/davidallison/StudioProjects/Anki-Android/AnkiDroid/src/main/res/values-pl/01-core.xml:155: Error: should use unicode '…' instead of three dots for ellipsis [TranslationTypo from com.ichi2.anki:lint-rules] Anulowanie...\nTo może chwilę zająć. ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /Users/davidallison/StudioProjects/Anki-Android/AnkiDroid/src/main/res/values-ru/01-core.xml:155: Error: should use unicode '…' instead of three dots for ellipsis [TranslationTypo from com.ichi2.anki:lint-rules] Отмена...\nЭто может занять некоторое время. ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /Users/davidallison/StudioProjects/Anki-Android/AnkiDroid/src/main/res/values-vi/01-core.xml:196: Error: should use unicode '…' instead of three dots for ellipsis [TranslationTypo from com.ichi2.anki:lint-rules] Đang sao chép... ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /Users/davidallison/StudioProjects/Anki-Android/AnkiDroid/src/main/res/values-vi/01-core.xml:198: Error: should use unicode '…' instead of three dots for ellipsis [TranslationTypo from com.ichi2.anki:lint-rules] Đang tính toán dung lượng cài đặt... ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /Users/davidallison/StudioProjects/Anki-Android/AnkiDroid/src/main/res/values-bn/01-core.xml:202: Error: should use unicode '…' instead of three dots for ellipsis [TranslationTypo from com.ichi2.anki:lint-rules] কপি চলছে... ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /Users/davidallison/StudioProjects/Anki-Android/AnkiDroid/src/main/res/values-ca/01-core.xml:202: Error: should use unicode '…' instead of three dots for ellipsis [TranslationTypo from com.ichi2.anki:lint-rules] Copiant... ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /Users/davidallison/StudioProjects/Anki-Android/AnkiDroid/src/main/res/values-fr/01-core.xml:202: Error: should use unicode '…' instead of three dots for ellipsis [TranslationTypo from com.ichi2.anki:lint-rules] Copie... ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /Users/davidallison/StudioProjects/Anki-Android/AnkiDroid/src/main/res/values-hu/01-core.xml:202: Error: should use unicode '…' instead of three dots for ellipsis [TranslationTypo from com.ichi2.anki:lint-rules] Másolás... ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /Users/davidallison/StudioProjects/Anki-Android/AnkiDroid/src/main/res/values-te/01-core.xml:202: Error: should use unicode '…' instead of three dots for ellipsis [TranslationTypo from com.ichi2.anki:lint-rules] కాపీ చేస్తోంది... ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /Users/davidallison/StudioProjects/Anki-Android/AnkiDroid/src/main/res/values-bn/01-core.xml:204: Error: should use unicode '…' instead of three dots for ellipsis [TranslationTypo from com.ichi2.anki:lint-rules] স্থানান্তরিত ডাটার সাইজ গণনা হচ্ছে... ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /Users/davidallison/StudioProjects/Anki-Android/AnkiDroid/src/main/res/values-ca/01-core.xml:204: Error: should use unicode '…' instead of three dots for ellipsis [TranslationTypo from com.ichi2.anki:lint-rules] Calculant la mida de la transferència... ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /Users/davidallison/StudioProjects/Anki-Android/AnkiDroid/src/main/res/values-hu/01-core.xml:204: Error: should use unicode '…' instead of three dots for ellipsis [TranslationTypo from com.ichi2.anki:lint-rules] Átviteli méret kiszámítása... ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /Users/davidallison/StudioProjects/Anki-Android/AnkiDroid/src/main/res/values-pt-rBR/01-core.xml:204: Error: should use unicode '…' instead of three dots for ellipsis [TranslationTypo from com.ichi2.anki:lint-rules] Calculando tamanho de transferência... ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /Users/davidallison/StudioProjects/Anki-Android/AnkiDroid/src/main/res/values-hr/01-core.xml:208: Error: should use unicode '…' instead of three dots for ellipsis [TranslationTypo from com.ichi2.anki:lint-rules] Kopiranje... ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /Users/davidallison/StudioProjects/Anki-Android/AnkiDroid/src/main/res/values-ru/01-core.xml:216: Error: should use unicode '…' instead of three dots for ellipsis [TranslationTypo from com.ichi2.anki:lint-rules] Вычисление размеров файлов для переноса... ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /Users/davidallison/StudioProjects/Anki-Android/AnkiDroid/src/main/res/values-tt/02-strings.xml:153: Error: should use unicode '…' instead of three dots for ellipsis [TranslationTypo from com.ichi2.anki:lint-rules] Колода бетерелә... ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /Users/davidallison/StudioProjects/Anki-Android/AnkiDroid/src/main/res/values-bn/02-strings.xml:155: Error: should use unicode '…' instead of three dots for ellipsis [TranslationTypo from com.ichi2.anki:lint-rules] ডেক মুছছি... ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /Users/davidallison/StudioProjects/Anki-Android/AnkiDroid/src/main/res/values-ca/02-strings.xml:155: Error: should use unicode '…' instead of three dots for ellipsis [TranslationTypo from com.ichi2.anki:lint-rules] S\'està suprimint el paquet...\nUn moment si us plau. ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /Users/davidallison/StudioProjects/Anki-Android/AnkiDroid/src/main/res/values-fa/02-strings.xml:155: Error: should use unicode '…' instead of three dots for ellipsis [TranslationTypo from com.ichi2.anki:lint-rules] حذف دسته کارت...\nلطفا صبر کنید. ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /Users/davidallison/StudioProjects/Anki-Android/AnkiDroid/src/main/res/values-hu/02-strings.xml:155: Error: should use unicode '…' instead of three dots for ellipsis [TranslationTypo from com.ichi2.anki:lint-rules] Pakli törlése...\nKérlek, várj... ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /Users/davidallison/StudioProjects/Anki-Android/AnkiDroid/src/main/res/values-nl/02-strings.xml:155: Error: should use unicode '…' instead of three dots for ellipsis [TranslationTypo from com.ichi2.anki:lint-rules] Leerset verwijderen...\nEven wachten. ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /Users/davidallison/StudioProjects/Anki-Android/AnkiDroid/src/main/res/values-ro/02-strings.xml:157: Error: should use unicode '…' instead of three dots for ellipsis [TranslationTypo from com.ichi2.anki:lint-rules] Ştergerea pachet...\nVa rugam aşteptaţi. ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /Users/davidallison/StudioProjects/Anki-Android/AnkiDroid/src/main/res/values-sr/02-strings.xml:157: Error: should use unicode '…' instead of three dots for ellipsis [TranslationTypo from com.ichi2.anki:lint-rules] Брисање шпила...\nМолим сачекајте. ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /Users/davidallison/StudioProjects/Anki-Android/AnkiDroid/src/main/res/values-pl/02-strings.xml:159: Error: should use unicode '…' instead of three dots for ellipsis [TranslationTypo from com.ichi2.anki:lint-rules] Usuwanie talii...\nProszę czekać... ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /Users/davidallison/StudioProjects/Anki-Android/AnkiDroid/src/main/res/values-fr/02-strings.xml:169: Error: should use unicode '…' instead of three dots for ellipsis [TranslationTypo from com.ichi2.anki:lint-rules] Préparation de l\'export... ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /Users/davidallison/StudioProjects/Anki-Android/AnkiDroid/src/main/res/values-hu/02-strings.xml:169: Error: should use unicode '…' instead of three dots for ellipsis [TranslationTypo from com.ichi2.anki:lint-rules] Exportálás előkészítése... ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /Users/davidallison/StudioProjects/Anki-Android/AnkiDroid/src/main/res/values-te/02-strings.xml:169: Error: should use unicode '…' instead of three dots for ellipsis [TranslationTypo from com.ichi2.anki:lint-rules] ఎగుమతి చేయడానికి సిద్ధమవుతోంది... ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /Users/davidallison/StudioProjects/Anki-Android/AnkiDroid/src/main/res/values-pl/02-strings.xml:173: Error: should use unicode '…' instead of three dots for ellipsis [TranslationTypo from com.ichi2.anki:lint-rules] Trwa przygotowywanie do eksportu... ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /Users/davidallison/StudioProjects/Anki-Android/AnkiDroid/src/main/res/values-ckb/03-dialogs.xml:114: Error: should use unicode '…' instead of three dots for ellipsis [TranslationTypo from com.ichi2.anki:lint-rules] ...Medyayê kontrol dike ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /Users/davidallison/StudioProjects/Anki-Android/AnkiDroid/src/main/res/values-ku/03-dialogs.xml:114: Error: should use unicode '…' instead of three dots for ellipsis [TranslationTypo from com.ichi2.anki:lint-rules] ...Medyayê kontrol dike ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /Users/davidallison/StudioProjects/Anki-Android/AnkiDroid/src/main/res/values-hu/03-dialogs.xml:122: Error: should use unicode '…' instead of three dots for ellipsis [TranslationTypo from com.ichi2.anki:lint-rules] Média törlése... ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /Users/davidallison/StudioProjects/Anki-Android/AnkiDroid/src/main/res/values-mr/03-dialogs.xml:133: Error: should use unicode '…' instead of three dots for ellipsis [TranslationTypo from com.ichi2.anki:lint-rules] रिक्त कार्ड शोधत आहे ... ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /Users/davidallison/StudioProjects/Anki-Android/AnkiDroid/src/main/res/values-nl/03-dialogs.xml:133: Error: should use unicode '…' instead of three dots for ellipsis [TranslationTypo from com.ichi2.anki:lint-rules] Lege kaarten aan het zoeken... ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /Users/davidallison/StudioProjects/Anki-Android/AnkiDroid/src/main/res/values-az/05-feedback.xml:53: Error: should use unicode '…' instead of three dots for ellipsis [TranslationTypo from com.ichi2.anki:lint-rules] AnkiDroid bir problemlə qarşılaşdı; inkişaf etdiricilərə hesabat göndərilir... ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /Users/davidallison/StudioProjects/Anki-Android/AnkiDroid/src/main/res/values-bn/05-feedback.xml:54: Error: should use unicode '…' instead of three dots for ellipsis [TranslationTypo from com.ichi2.anki:lint-rules] AnkiDroid সমস্যার সম্মুখীন হয়েছে; ডেভেলপারদের কাছে একটি প্রতিবেদন পাঠানো হচ্ছে... ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /Users/davidallison/StudioProjects/Anki-Android/AnkiDroid/src/main/res/values-hu/05-feedback.xml:54: Error: should use unicode '…' instead of three dots for ellipsis [TranslationTypo from com.ichi2.anki:lint-rules] Hiba riport készül a fejlesztőknek... ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /Users/davidallison/StudioProjects/Anki-Android/AnkiDroid/src/main/res/values-nl/05-feedback.xml:54: Error: should use unicode '…' instead of three dots for ellipsis [TranslationTypo from com.ichi2.anki:lint-rules] Een foutrapport wordt voorbereid voor de ontwikkelaars... ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /Users/davidallison/StudioProjects/Anki-Android/AnkiDroid/src/main/res/values-bn/05-feedback.xml:55: Error: should use unicode '…' instead of three dots for ellipsis [TranslationTypo from com.ichi2.anki:lint-rules] ডেভেলপারদের জন্য একটি ত্রুটি রিপোর্ট প্রস্তুত করা হচ্ছে... ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /Users/davidallison/StudioProjects/Anki-Android/AnkiDroid/src/main/res/values-az/09-backup.xml:60: Error: should use unicode '…' instead of three dots for ellipsis [TranslationTypo from com.ichi2.anki:lint-rules] Verilənlər bazası təmiri... ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /Users/davidallison/StudioProjects/Anki-Android/AnkiDroid/src/main/res/values-ca/09-backup.xml:60: Error: should use unicode '…' instead of three dots for ellipsis [TranslationTypo from com.ichi2.anki:lint-rules] S\'està reparant la base de dades.\nUn moment si us plau... ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /Users/davidallison/StudioProjects/Anki-Android/AnkiDroid/src/main/res/values-et/09-backup.xml:60: Error: should use unicode '…' instead of three dots for ellipsis [TranslationTypo from com.ichi2.anki:lint-rules] Parandan andmebaasi... ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /Users/davidallison/StudioProjects/Anki-Android/AnkiDroid/src/main/res/values-nl/09-backup.xml:60: Error: should use unicode '…' instead of three dots for ellipsis [TranslationTypo from com.ichi2.anki:lint-rules] Database herstellen.\nEven wachten... ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /Users/davidallison/StudioProjects/Anki-Android/AnkiDroid/src/main/res/values-pl/09-backup.xml:60: Error: should use unicode '…' instead of three dots for ellipsis [TranslationTypo from com.ichi2.anki:lint-rules] Naprawianie bazy danych.\nProszę czekać... ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /Users/davidallison/StudioProjects/Anki-Android/AnkiDroid/src/main/res/values-sr/09-backup.xml:60: Error: should use unicode '…' instead of three dots for ellipsis [TranslationTypo from com.ichi2.anki:lint-rules] Обнављање базе података.\nМолим сачекајте... ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /Users/davidallison/StudioProjects/Anki-Android/AnkiDroid/src/main/res/values-sv/09-backup.xml:60: Error: should use unicode '…' instead of three dots for ellipsis [TranslationTypo from com.ichi2.anki:lint-rules] Reparerar databas.\nVar vänlig vänta... ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /Users/davidallison/StudioProjects/Anki-Android/AnkiDroid/src/main/res/values-ta/09-backup.xml:60: Error: should use unicode '…' instead of three dots for ellipsis [TranslationTypo from com.ichi2.anki:lint-rules] பழுதுபார்க்கும் தரவுத்தளம்... ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /Users/davidallison/StudioProjects/Anki-Android/AnkiDroid/src/main/res/values-zh-rCN/09-backup.xml:60: Error: should use unicode '…' instead of three dots for ellipsis [TranslationTypo from com.ichi2.anki:lint-rules] 修复数据库。 \n 请稍候... ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /Users/davidallison/StudioProjects/Anki-Android/AnkiDroid/src/main/res/values-de/10-preferences.xml:322: Error: should use unicode '…' instead of three dots for ellipsis [TranslationTypo from com.ichi2.anki:lint-rules] Kalku-\nlieren... ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /Users/davidallison/StudioProjects/Anki-Android/AnkiDroid/src/main/res/values-sv/10-preferences.xml:324: Error: should use unicode '…' instead of three dots for ellipsis [TranslationTypo from com.ichi2.anki:lint-rules] Be-\nräknar... ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /Users/davidallison/StudioProjects/Anki-Android/AnkiDroid/src/main/res/values-sv/10-preferences.xml:336: Error: should use unicode '…' instead of three dots for ellipsis [TranslationTypo from com.ichi2.anki:lint-rules] Tar bort säkerhetskopior... ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /Users/davidallison/StudioProjects/Anki-Android/AnkiDroid/src/main/res/values-sv/10-preferences.xml:342: Error: should use unicode '…' instead of three dots for ellipsis [TranslationTypo from com.ichi2.anki:lint-rules] Tar bort samling... ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /Users/davidallison/StudioProjects/Anki-Android/AnkiDroid/src/main/res/values-de/10-preferences.xml:357: Error: should use unicode '…' instead of three dots for ellipsis [TranslationTypo from com.ichi2.anki:lint-rules] Rufe ab... ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /Users/davidallison/StudioProjects/Anki-Android/AnkiDroid/src/main/res/values-de/10-preferences.xml:358: Error: should use unicode '…' instead of three dots for ellipsis [TranslationTypo from com.ichi2.anki:lint-rules] Berechnen... ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /Users/davidallison/StudioProjects/Anki-Android/AnkiDroid/src/main/res/values-fr/10-preferences.xml:358: Error: should use unicode '…' instead of three dots for ellipsis [TranslationTypo from com.ichi2.anki:lint-rules] Récupération en cours... ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /Users/davidallison/StudioProjects/Anki-Android/AnkiDroid/src/main/res/values-ca/10-preferences.xml:359: Error: should use unicode '…' instead of three dots for ellipsis [TranslationTypo from com.ichi2.anki:lint-rules] S\'està obtenint dades... ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /Users/davidallison/StudioProjects/Anki-Android/AnkiDroid/src/main/res/values-cs/20-search-preference.xml:63: Error: should use unicode '…' instead of three dots for ellipsis [TranslationTypo from com.ichi2.anki:lint-rules] Vyhledat... ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
david-allison commented 2 weeks ago

I'm struggling with RTL languages.

I would propose that we ignore these for now in this PR, I'd rather my string fixes were correct, and I can't guarantee this with Arabic/Hebrew etc...

david-allison commented 2 weeks ago

The string Sync unexpectedly reset 2 strings.

I need to fix these

Then, I have CrowdIn down to <10 bad translations

Then we can merge the string sync

Then we can get this in

david-allison commented 2 weeks ago
david-allison commented 2 weeks ago

@Aditya13s In future, could you branch off main, when making PRs, it makes it slightly more difficult to rebase (and likely blocks you from making concurrent pull requests)

david-allison commented 2 weeks ago

This is done. Pending a string translation due to two recently added, and broken strings

david-allison commented 2 weeks ago

Blocked on https://github.com/ankidroid/Anki-Android/pull/16285, then good to go