Closed Aditya13s closed 2 weeks ago
Requires manual work from reviewers to fix current translations and the reference strings that get uploaded to crowdin.
Interesting on the manual work comment:
Don't change the keys, very limited value
The initial aim of the issue was to catch bad translations
This has morphed into also catching bad strings in /values
There's a different approach in the two:
The next step is to get a map from key
to bad [string/translation]
. I'll take this on
Strings
dialog_processing
export_send_no_handlers
Translations
pref__etc__snackbar__calculating
pref__etc__snackbar__fetching
searchpreference_search
progress__deleting_collection
progress__deleting_backups
pref__widget_text__calculating
thirdparty_apps_summary
backup_repair_deck_progress
export_preparation_in_progress
export_share_title
delete_deck
feedback_for_manual_toast_text
feedback_auto_toast_text
sign_in
emtpy_cards_finding
delete_media_message
check_media_message
export_choice_save_to
migration__calculating_transfer_size
migration__copying
sync_conflict_replace_title
sync_cancel_message
empty_filtered_deck
rebuild_filtered_deck
My fault! Sorry about the close
I'm running a translation sync.
I've fixed a number of the above translations and all the strings
- 383 errors, 0 warnings
+ 79 errors
I'm struggling with RTL languages.
I would propose that we ignore these for now in this PR, I'd rather my string fixes were correct, and I can't guarantee this with Arabic/Hebrew etc...
The string Sync unexpectedly reset 2 strings.
I need to fix these
Then, I have CrowdIn down to <10 bad translations
Then we can merge the string sync
Then we can get this in
main
ar
, fa
, ckb
, heb
, ur
…
appears incorrectly in GitHub, and we don't want to overload our reviewers with knowing whether they're making correct changes@Aditya13s In future, could you branch off main
, when making PRs, it makes it slightly more difficult to rebase (and likely blocks you from making concurrent pull requests)
This is done. Pending a string translation due to two recently added, and broken strings
Blocked on https://github.com/ankidroid/Anki-Android/pull/16285, then good to go
Purpose / Description
This PR addresses a lint improvement in which
...
is replaced with unicode…
.Fixes
Approach
Added a function in
TranslationTypo.visitElement()
to check if the text contains...
or not.How Has This Been Tested?
I test by running lint test and it shows `Error: should use unicode '…' instead of three dots for ellipsis [TranslationTypo from com.ichi2.anki:lint-rules]