ankidroid / Anki-Android

AnkiDroid: Anki flashcards on Android. Your secret trick to achieve superhuman information retention.
GNU General Public License v3.0
8.41k stars 2.18k forks source link

Proposal: improve the 'Translation Sync' message #16980

Open david-allison opened 2 weeks ago

david-allison commented 2 weeks ago

Before

Message to maintainers, this PR contains strings changes.

  1. Before merging this PR, it is best to run the "Sync Translations" GitHub action, then make and merge a PR from the i18n_sync branch to get translations cleaned out.
  2. Then merge this PR, and immediately do another translation PR so the huge change made by this PR's key changes are all by themselves.

Read more about updating strings on the wiki,


After

[!IMPORTANT] Maintainers: This PR contains https://github.com/ankidroid/Anki-Android/labels/Strings changes

  1. Sync Translations before merging this PR and wait for the action to complete
  2. Find the auto-generated PR and open and close the PR to perform a lint check. Review and merge the PR to sync all user-submitted translations
  3. Merge this PR
  4. Sync Translations again and merge the PR so the huge automated string changes caused by merging this PR are by themselves and easy to review
david-allison commented 2 weeks ago

I'm proposing this as:


Location:

https://github.com/ankidroid/Anki-Android/blob/701b5582de43fa0742ddf8964034ed5bce82c274/.github/workflows/label.yml#L128-L140

BrayanDSO commented 2 weeks ago

Read more about updating strings on the wiki,

localization-administration download-localized-strings

Can this part be condensed into a single line? Or link to a single page in the forums that will do the rest of the guiding

I like the changes, but now the whole message takes a considerable amount of vertical space

lukstbit commented 2 weeks ago

Looks fine, but I don't see the purpose of the last line:

Read more about updating strings on the wiki

if the message targets us maintainers.