Closed jradchaima closed 6 days ago
First PR! 🚀 We sincerely appreciate that you have taken the time to propose a change to AnkiDroid! Please have patience with us as we are all volunteers - we will get to this as soon as possible.
Hi @mikehardy ,I updated two AndroidManifest.xml files, and the lint build was successful when I tested on Android studio
I made some errors while updating the branch with the latest changes. I've resolved them and ensured everything is now up-to-date. Please let me know if there's anything else you'd like me to check!
The "proper" way to update the branch in AnkiDroid is never to do a merge commit - for future reference. We do a rebase-merge strategy here which is a bit unusual based on my experience interacting with other developers but results in a very very clean commit history, which is something we value
Happy to accept the merge commit this time and do a squash-merge of this PR - no problems - but if you plan to contribute to AnkiDroid in the future maybe do some test PR work on your personal Anki-Android repo fork where you locally rebase a PR pulling changes into your branch that way, then force-push back out to your branch. A bit difficult to get used to at first but then pretty easy after some practice
Thank you so much for the advice!
Purpose / Description
17425
The lint build fails with the following error: "Error: For locale "ca" (Catalan) the following quantity should also be defined: many "[MissingQuantity] to solve this error I Revert lint rule changes [UnusedQuantity, MissingQuantity] from fatal to ignore
Fixes
Approach
I made modifications to two AndroidManifest.xml AnkiDroid/src/main/AndroidManifest.xml testlib/src/main/AndroidManifest.xml in lint-release.xml I changed thes two line from
to
These changes fix the lint build failure, making the build successful
How Has This Been Tested?
tested on emulator Google HPE device
Learning (optional, can help others)
Describe the research stage
Links to blog posts, patterns, libraries or addons used to solve this problem
Checklist
Please, go through these checks before submitting the PR.