no menu button during review on galaxy nexus

[hssm]

Originally reported on Google Code with ID 937

The Galaxy Nexus does not have a built-in Menu button, instead, apps get to choose where
to put it (it shows as 3 dots). An app that doesn't choose, should have those 3 dots
show up down beside the home/back/etc buttons. 

For whatever reason, when reviewing cards, anki-droid shows no menu button anywhere
which is a serious loss of functionality.

On the other screens, the menu button appears as 3 dots in the top-right.

Toggling full-screen review mode seems to make no difference.

Reported by fergald on 2012-01-09 04:11:15

[hssm]

Interesting.
Could you find the URLs of some screenshots showing this Galaxy Nexus UI?
Thanks for your feedback!

Reported by nicolas.raoul on 2012-01-09 04:22:12

[hssm]

It's an ICS/Honeycomb thing, and really serious for devices without physical menu buttons
since it renders Ankidroid unusable.

There's no menu button anywhere in Ankidroid on my Nook Color with CM9, or on a previous
stock Galaxy Tab 10.1 with Honeycomb (now returned). All other apps work fine, with
a menu button popping up either in the status bar or in the top right corner.

Interestingly, the virtual menu button in the status bar worked flawlessly in CM7 for
the Nook Color.

Reported by ivar.padron on 2012-01-22 12:51:43

[hssm]

Update: In 1.1 beta 7, there's a menu button in the upper-right corner of the deck picker
and study options screens (Nook Color, CM9 nightly). I'm only missing it in the review
screen now.

Reported by ivar.padron on 2012-01-23 10:00:17

[hssm]

I will have a look.
I fixed a similar issue in the StudyOptions screen some time ago.

Reported by flerda on 2012-01-23 20:06:20

• Status changed: Started

[hssm]

Hi Flavio,

I reported a fixed a similar issue (961) yesterday. My solution is not perfect, but
it did the trick in my tablet.

Hope it helps.
Kostas

Reported by inigo.aldana on 2012-01-24 02:05:11

[hssm]

https://github.com/flerda/Anki-Android/commit/b8af45957ea5741c8bcb86d6147b21b60d7d8773

This changes all of Honeycomb+ devices to use the action bar.
Most system apps in ICS use it and user expect it,
so I think it is fine that way.

Reported by flerda on 2012-01-24 07:23:09

[hssm]

Hi, I have the same issue with the latest beta on my galaxy tab 10.1.
I understand that a fix was made using a adapted theme. But how can I use this theme?
Any help would be greatly appreciated. 

Reported by haraldstoll on 2012-01-24 15:08:06

[hssm]

I fixed this issue locally. I cant't get eclipse to generate a proper patch, so:

In package com.ichi2.anki in Reviewer.java in method onPrepareOptionsMenu
I replaced:
        if (mCurrentCard == null){
            return false;
        }
        if (mCurrentCard.isMarked()) {
with:

        if (mCurrentCard != null && mCurrentCard.isMarked()) {

Regards,
Thomas

Reported by thesing.thomas on 2012-01-27 21:34:17

[hssm]

thank you got your reply. i have managed to find a couple of more recent .apk's that
rolled out soon after my version. it has been fixed.
I'm truly rejoiced!

Reported by haraldstoll on 2012-01-28 04:10:27

[hssm]

Thanks for the patch Thomas Thesing!
I replaced like you said and released a new beta (beta10).
Please everyone test it to check whether it solves the problem.
Cheers!

Reported by nicolas.raoul on 2012-01-29 07:56:19

• Status changed: FixedInDev

[hssm]

Fixed in version 1.1, available on Google Play

Reported by nicolas.raoul on 2012-03-23 08:00:47

• Status changed: Fixed