search

ankidroid / Anki-Android

AnkiDroid: Anki flashcards on Android. Your secret trick to achieve superhuman information retention.
GNU General Public License v3.0
8.52k stars 2.21k forks source link

Change Zeemote to Opensource or transfer it to a plugin #1974

Closed hssm closed 6 years ago

hssm commented 9 years ago

Originally reported on Google Code with ID 1072

The master of AnkiDroid currently contains proprietary code, so it can not strictly
be called Open Source.

The proprietary blobs are the Zeemote jars:
https://github.com/nicolas-raoul/Anki-Android/tree/master/libs

I attach the Zeemote EULA, you can see it is very restricted. Of course, the source
code of the jars is not open source, it is not even distributed.

Why it is a problem:
- Using only Open Source is important for many people.
- Including a proprietary blob with unknown source is a security risk.

We might have to remove Zeemote support because of that.
An optimist view could be to hope that an open source driver will be released.

Meanwhile, only the nobluetooth branch is strictly Open Source.

Reported by nicolas.raoul on 2012-03-21 10:16:05

hssm commented 9 years ago 
mmhh. too bad. But there is probably no other way then removing it

Reported by NorbertNagold on 2012-03-21 12:32:57

hssm commented 9 years ago 
How about switching branches?

master -> zeemote
nobluetooth -> master

APKs with Zeemote support would be available for downloads, but most people would have
the 100% open source version.

Before doing this, we should ask Zeemote to make their driver Open Source, it is in
their interest. For them, that could be a way to make their product trendy again after
two years of low activity: http://www.google.com/trends/?q=zeemote,MIUI

Are many people using Zeemote?

Reported by nicolas.raoul on 2012-03-21 13:26:13

hssm commented 9 years ago 
I don't imagine zeemote support is particularly popular, so why not ask the original
contributor of the code to maintain their own branch?

Reported by dae@ichi2.net on 2012-03-21 14:35:00

hssm commented 9 years ago 
I removed zeemote in master and reactivated in branch zeemote (https://github.com/nobnago/Anki-Android/tree/zeemote)

Reported by NorbertNagold on 2012-05-14 22:17:09

hssm commented 9 years ago

Reported by NorbertNagold on 2012-05-14 22:18:17

hssm commented 9 years ago

Reported by inigo.aldana on 2012-05-15 08:31:58

hssm commented 9 years ago

Reported by inigo.aldana on 2012-09-05 08:57:23

hssm commented 9 years ago

Reported by inigo.aldana on 2013-01-20 18:53:26

hssm commented 9 years ago 
hi, i can see that in 'AnkiDroid-2.1alpha1'
this was added:
'new: plugin archictecture (e.g. for using Zeemote)'
and so i can install 'AnkiDroid-Zeemote-0.8.apk', adn use my zeemote with ankidroid.

with the latest ankidroid, 'AnkiDroid-2.1alpha2', was the plugin system removed? i
cannot see it in the preferences menu.
thanks for adding it though :)

Reported by woof.addict on 2013-02-25 03:01:57

hssm commented 9 years ago 
Nicolas, did you pull my master branch before releasing alpha2?

Reported by NorbertNagold on 2013-02-27 10:13:14

hssm commented 9 years ago

Reported by NorbertNagold on 2013-02-27 10:13:24

hssm commented 9 years ago 
2.1alpha2 is this commit:
https://github.com/ankidroid/Anki-Android/commit/0097f12e84c01012c04eaa39a798af4087af03d9

As far as the network graph shows, 2.1alpha2 includes all your 2013 commits that have
not been merged into 2.0.1-dev

By the way, 2.0.1-dev should be merged into 2.1-dev.

Reported by nicolas.raoul on 2013-02-27 10:23:37

hssm commented 9 years ago 
Even with alpha 4, the plugin system does not seem to be present, and I cannot use the
anki plugin, have I done something wrong?

Reported by woof.addict on 2013-08-24 13:18:00

hssm commented 9 years ago 
Issue 1124 has been merged into this issue.

Reported by perceptualchaos2 on 2015-06-02 08:49:01

hssm commented 9 years ago 
Issue 1183 has been merged into this issue.

Reported by perceptualchaos2 on 2015-06-02 09:00:42

hssm commented 9 years ago 
Nicolas posted some C code in issue 1183 which may be able to use, but I guess 
Zeemote is dead now...

Reported by perceptualchaos2 on 2015-06-02 09:01:46