search

ankidroid / Anki-Android

AnkiDroid: Anki flashcards on Android. Your secret trick to achieve superhuman information retention.
GNU General Public License v3.0
8.62k stars 2.23k forks source link

Widget: Notification & Sound each time I change AnkiDroid Activities #6476

Open david-allison opened 4 years ago

david-allison commented 4 years ago

2.12alpha6 Android 9.

I don't use notifications/widget generally, so this may be user error.

I have a test collection with 55 unseen cards

Notification settings: Notify when more than 10 cards due

Each time I lock my phone with AnkiDroid open, or load a new activity in AnkiDroid, I get a notification sound and notification with "55 cards due". Even if the notification is currently appearing, there's no grace period.

This is distracting and isn't a great user experience.

Caused by calling widget.update() onStop: https://github.com/ankidroid/Anki-Android/blob/b1135ff3cbd8d536a0175e7b9b156fdb88585e1b/AnkiDroid/src/main/java/com/ichi2/anki/CardBrowser.java#L683

This calls through to:

https://github.com/ankidroid/Anki-Android/blob/8ada06b2e6521aa4e9eff2a0539dc192ef89a894/AnkiDroid/src/main/java/com/ichi2/widget/WidgetStatus.java#L116

mikehardy commented 4 years ago

Yes it's pretty sucky at the moment. I have a "notifications refactor" branch alive on my fork but it had very little solid progress and wasn't as important as database corruption (5151) so has sat for nearly 2 years! I know a lot more about notifications now and would say that I think updating the notification (if it exists) as opposed to clearing and posting a new one is the correct way but everything about notifications in any app needs careful testing

github-actions[bot] commented 4 years ago

Hello 👋, this issue has been opened for more than 2 months with no activity on it. If the issue is still here, please keep in mind that we need community support and help to fix it! Just comment something like still searching for solutions and if you found one, please open a pull request! You have 7 days until this gets closed automatically

github-actions[bot] commented 4 years ago

Hello 👋, this issue has been opened for more than 2 months with no activity on it. If the issue is still here, please keep in mind that we need community support and help to fix it! Just comment something like still searching for solutions and if you found one, please open a pull request! You have 7 days until this gets closed automatically

github-actions[bot] commented 3 years ago

Hello 👋, this issue has been opened for more than 2 months with no activity on it. If the issue is still here, please keep in mind that we need community support and help to fix it! Just comment something like still searching for solutions and if you found one, please open a pull request! You have 7 days until this gets closed automatically

github-actions[bot] commented 3 years ago

Hello 👋, this issue has been opened for more than 2 months with no activity on it. If the issue is still here, please keep in mind that we need community support and help to fix it! Just comment something like still searching for solutions and if you found one, please open a pull request! You have 7 days until this gets closed automatically

dae commented 1 year ago

@david-allison still happening?