ankidroid / Anki-Android

AnkiDroid: Anki flashcards on Android. Your secret trick to achieve superhuman information retention.
GNU General Public License v3.0
8.81k stars 2.25k forks source link

Handle new Github Action Runner - defaults to JDK11 #8270

Closed mikehardy closed 3 years ago

mikehardy commented 3 years ago
Reproduction Steps
  1. Attempt to run the "publish" workflow
Expected Result

Publishes successfully

Actual Result

Fails while verifying the JDK in the environment is JDK8: https://github.com/ankidroid/Anki-Android/runs/2142332643?check_suite_focus=true#step:4:4

https://github.com/actions/virtual-environments/blob/ubuntu20/20210315.1/images/linux/Ubuntu2004-README.md#java

Research

GitHub just switched their runners from an older Ubuntu to a newer one, and switched default JVM at the same time I presume

Things to check:

mikehardy commented 3 years ago

Releases are blocked until I resolve this but it is not open for outside contribution. Should get it today.

mikehardy commented 3 years ago

jdk11 bundled in next android studio and becomes minimum target https://developer.android.com/studio/preview/features?hl=sr#agp-7-0-jdk-11

so rolling forward is my first cut strategy

mikehardy commented 3 years ago

Fixed in https://github.com/ankidroid/Anki-Android/commit/698c20673b53d15cbeda6ee74ef486663bd64d2b and https://github.com/ankidroid/Anki-Android/commit/9ce8c4aa73a7957e168d3c3f204f949194586ef3