ankit / stylebot

Change the appearance of the web instantly
https://stylebot.dev/
MIT License
1.38k stars 205 forks source link

[Bug] URL Syntax Wildcards not working #700

Closed GittyBruce closed 2 years ago

GittyBruce commented 2 years ago

Describe the bug

Including wildcards anywhere in the URL field prevents matching. e.g. https://github.com/*/stylebot or https://github.com/**/stylebot fail to match https://github.com/ankit/stylebot.

Browser

Ungoogled Chromium v.102. Win 10 x64.

To Reproduce

Create style with https://github.com/*/stylebot in field name Go to https://github.com/ankit/stylebot Check whether style is active

Expected behavior

I would expect https://github.com/*/stylebot to match https://github.com/ANYTEXT/stylebot and it's subdomains. Similarly, I would expect https://github.com/** to match any github subdomain.

Screenshots

Image shows created style with url https://github.com/*/stylebot image Image shows style not matched to https://github.com/ankit/stylebot image

Additional context

Regexp wild cards work as expected.

ankit commented 2 years ago

fixed in https://github.com/ankit/stylebot/commit/fa8f3da2d6b59da7ba98bc8a126b4d53339f37f1