Closed rmacklin closed 4 months ago
@ankit Are you still maintaining this repo? If so, would you consider merging this PR? If not, would you be open to updating the README to indicate that you are no longer maintaining it?
@rmacklin yes, I am maintaining it every now and then. I will merge your PR, thank you
Awesome, thank you!!
It seems that the usage of this dependency was removed in https://github.com/ankit/stylebot/commit/b7d2708110efc2177e1ae2fd0312109194d92714#diff-1fb26bc12ac780c7ad7325730ed09fc4c2c3d757c276c3dacc44bfe20faf166fL62-L64, so we don't actually need it. Furthermore, even though it doesn't appear to be used anywhere else, just having the package as a dependency breaks
yarn build
on node 16:and that
thread_id_key
error is apparently a well-known issue with the fibers package which doesn't support node 16: https://github.com/laverdet/node-fibers/commit/8f2809869cc92c28c92880c4a38317ae3dbe654dAfter removing the dependency, we can successfully run
yarn build
on node 16 (which is important, because earlier versions of node are not supported on darwin-arm64, a.k.a. Apple Silicon):