Comments left via the plugin hide line contents in AzDO preview

ankitbko / vscode-pull-request-azdo

Azure Devops Pull Requests for Visual Studio Code

https://marketplace.visualstudio.com/items?itemName=ankitbko.vscode-pull-request-azdo

MIT License

67 stars 21 forks source link

Comments left via the plugin hide line contents in AzDO preview #43

Open ottowayi opened 3 years ago

ottowayi commented 3 years ago

Extension version: 0.0.21
VSCode Version: 1.55.2
OS: Windows 10

Steps to Reproduce:

Checkout a PR in this plugin
Leave a comment on a line

Leaving a comment via this plugin in vscode causes the preview in AzDO to be missing all but the last character of the line the comment is set on

ankitbko commented 3 years ago

I did not understand it. Is the actual line max_line_length=100 not present in AzDO UI? Have you commited and pushed your changes?

ottowayi commented 3 years ago

Yeah there are no changes locally. This screenshot is from a PR that I checked out via the plugin and added the comment on line 36. When I view the comment in AzDO you can see it only shows the last character (0) for the line I left the comment on. It didn't modify the code, just whatever is used to show the comment location in the file. It doesn't break anything, but makes it hard to review comments in AzDO because you lose the line that the comment was left on.

ankitbko commented 3 years ago

Adding a comment will not change the line itself. The AzDO UI will show what is the latest commit in the branch in remote. And VS Code will show whatever is the latest commit in local. Maybe you don't have the latest change? Could you do git fetch and then git pull.

serhey-88 commented 9 months ago

Hi there @ottowayi. I'm not sure if you are still supporting this extension, but I have the same issue as @ottowayi. I tried to make fetch and pull but it didn't help. Here is my example. I try to comment on the line 8 and on AzDO UI I can see only the last symbol which is coma instead of full line: