search

ankitbko / vscode-pull-request-azdo

Azure Devops Pull Requests for Visual Studio Code
https://marketplace.visualstudio.com/items?itemName=ankitbko.vscode-pull-request-azdo
MIT License
64 stars 23 forks source link

Mentions in comments are not resolved to user and no hover support #48

Open sheldonhull opened 3 years ago

sheldonhull commented 3 years ago

After beginning report I noticed this at the bottom under known issues. Could not find an open issue for this.

Recommend highlighting this at the top of the readme rather than bottom to make it very clear upfront.

User name isn't being resolved with @name and is coming back as guid in rendering.

2021-06-11-13 09 10-Code

ankitbko commented 3 years ago

Yes this is known issue. I will need to think about how to implement this. The comment API does not provide any way to display a particular segment of string as some other string. That means even if I am able to correlate the id with the user, I will need to modify the actual comment content to replace the id with the user's name and display that. The problem arises what if the person edits the comment and submits. Then I will need to replace the name with the id before submitting the edit. This is same problem as mentioning a user in comment so this needs to be solved first. The problem there is to actually convert a "name" to the id. Need to think about this a bit.