ankitects / anki-manual

Anki's manual
https://docs.ankiweb.net
473 stars 167 forks source link

Update deck options related to FSRS.md #218

Closed Expertium closed 1 month ago

Expertium commented 1 month ago

It's been a while since these have been updated in the manual. For example, having 1000+ reviews is no longer required. Some names have changed. Btw, I renamed "Ignore reviews before" to "Ignore cards reviewed before". I will also edit the section about fuzz once Load Balancer is implemented. So this shouldn't be merged until the next release of Anki, this is a draft. @user1823 feel free make more edits, since the Github guide is updated much more frequently, and there may be some outdated info in the manual that I have missed.

user1823 commented 1 month ago

Is it really worth maintaining two guides (one in the Anki manual and one in the FSRS repo)? Shouldn't we try to merge these (or at least minimize duplication by linking to each other)?

Expertium commented 1 month ago

Ideally yes, but that would require translating the Github manual into other languages.

brishtibheja commented 1 month ago

I was about to update everything in the deck options page today. I read my pdf and annotated everything last night lol. Two minor suggestions: 1. Update the heading hierarchy. 2. Mention hard limit of Optimise in previous versions.

brishtibheja commented 1 month ago

I suggest to hold off changing fuzz's section or changing name of 'Ignore reviews before'. Those can be done later. Let's merge these changes for now.

Expertium commented 1 month ago

Update the heading hierarchy

I don't really understand what you mean.

Mention hard limit of Optimise in previous versions

I'm not sure if keeping notes about such changes is useful. It may seem useful at first, but at the rate of development of FSRS, in a year or two there will be too many notes documenting things about past versions. But ok, I'll add it.

I suggest to hold off changing fuzz's section or changing name of 'Ignore reviews before'.

I'd like to wait for the next major Anki release and merge it then

brishtibheja commented 1 month ago

I'd like to wait for the next major Anki release and merge it then

I'll then have to hold off changes I want to make lest I introduce some conflicts. This can go now with the current 'Ignore reviews before' as the 'next version' will not change a lot of things.

In any case, one thing I meant to ask you to do was 'updating the workload/DR' graph. It uses the word 'retention' instead of 'desired retention' in the x axis. People are already confused about various retentions that are talked of.

Expertium commented 1 month ago

It uses the word 'retention' instead of 'desired retention' in the x axis.

I think it's fine

brishtibheja commented 1 month ago

@Expertium Deleted the fork?

brishtibheja commented 1 month ago

There seems to be a way of recreating that branch, would you try it? Or should I submit a PR later?

Expertium commented 1 month ago

I'll submit another PR later