ankitgoel23 / pleft

Automatically exported from code.google.com/p/pleft
GNU General Public License v3.0
0 stars 0 forks source link

Double-clicking the arrows in the calendar causes unintentional selections #49

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
What steps will reproduce the problem?
1. Go to http://www.pleft.com/
2. Click the arrow pointing downwards in the calendar widget.
3. Quickly click it again.

What is the expected output? What do you see instead?
Expected: scroll down two months.
Instead: scroll down two months and select the arrow.

Please use labels and text to provide additional information.
This should be easily fixable by some CSS and/or JavaScript.

Original issue reported on code.google.com by sander.d...@gmail.com on 7 Jul 2011 at 9:50

GoogleCodeExporter commented 8 years ago
Hi,

If you add the attribute href="javascript:void(0)" it will solve this issue 
(e.g. <a class="dp-choose .dp-down" href="javascript:void(0);">▼</a>).

Original comment by atnguy...@gmail.com on 31 Oct 2011 at 12:49

GoogleCodeExporter commented 8 years ago
Great, thanks!

If you'd like to be part of Pleft's code history, it would be cool if you send 
in a patch. See this page for help (especially 'Publishing changes', you can 
skip some other parts):
http://code.google.com/p/pleft/wiki/GettingStarted

Original comment by sander.d...@gmail.com on 31 Oct 2011 at 8:08

GoogleCodeExporter commented 8 years ago
[deleted comment]
GoogleCodeExporter commented 8 years ago
Cool! I've committed changes via git, thanks for the wiki, very useful.

Original comment by atnguy...@gmail.com on 1 Nov 2011 at 2:20

GoogleCodeExporter commented 8 years ago
Good to hear that you managed to commit it. Could you publish your changes? You 
could for example use the following command to create a patch file, that you 
can attach to this issue.

git format-patch master --stdout > prevent-selections.patch

(If you use Windows, you'll probably need to use Git Bash to run the command.)

Original comment by sander.d...@gmail.com on 1 Nov 2011 at 6:44

GoogleCodeExporter commented 8 years ago
[deleted comment]
GoogleCodeExporter commented 8 years ago
Oops, I think the GettingStarted page as well as my previous comment contained 
the wrong command. You probably need to use 'origin/master' instead of 'master' 
in order to not get an empty patch:

git format-patch origin/master --stdout > filename.patch

Original comment by sander.d...@gmail.com on 1 Nov 2011 at 6:59

GoogleCodeExporter commented 8 years ago
ahh ok, I was wondering why it turned up empty, alright, here is the patch 
file, let me know if you have any problems.

Original comment by atnguy...@gmail.com on 1 Nov 2011 at 7:14

Attachments:

GoogleCodeExporter commented 8 years ago
Thanks for the patch! And sorry for not getting back to you earlier.

I have been working on a jQuery version of Pleft, which makes it easier to 
modify the code. In this fork, I am now using a modification of your patch:
https://github.com/sander/pleft/commit/252c1780b2ba60778923dc2504429e3a9a68f3a4

My plan is to finish this rewrite before pushing any updates to pleft.com.

Original comment by sander.d...@gmail.com on 13 Nov 2011 at 8:38

GoogleCodeExporter commented 8 years ago
Fixed in http://tryout.pleft.com/

Original comment by sander.d...@gmail.com on 27 Nov 2011 at 3:57