ankittekri / connectbot

Automatically exported from code.google.com/p/connectbot
Apache License 2.0
0 stars 0 forks source link

Landscape Orientation should not be forced #57

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
So the G1 currently requires landscape for the keyboard to be open, but
that should not be assumed. Connectbot should behave more like other apps
(eg sms or mail) and keep the orientation the device has selected unless
told otherwise by the user.

Original issue reported on code.google.com by disconn...@gmail.com on 30 Oct 2008 at 4:04

GoogleCodeExporter commented 8 years ago
I agree. We should take out the screenOrientation="landscape" from the
ConsoleActivity. It seems to work fine since we have the resizePTY packets.

Original comment by kenny@the-b.org on 30 Oct 2008 at 5:13

GoogleCodeExporter commented 8 years ago
agreed, also becasue we dont know about future device resolutions/orientations.

the best way to approach this would be to request an orientation onCreate() 
based on
a preference.  that way landscape might be default, but could be set to 
automatic or
portrait if forced.

Original comment by Jeffrey.Sharkey on 30 Oct 2008 at 8:58

GoogleCodeExporter commented 8 years ago
I think just letting the application behave like the other applications is 
probably
the most intuitive.

Adding a preference that defaults to 'auto' would be fine with me as well.

vvaldo (I think) also had an idea of using the accelerometer to change 
orientation a
la iPod.

Original comment by kenny@the-b.org on 31 Oct 2008 at 5:58

GoogleCodeExporter commented 8 years ago
i slightly disagree with having it default to "auto".  people are almost always 
going
to pop out their keyboard, and its odd to have it resize when they push the 
keyboard
back in.

i agree that we could still give users the option (force land, force port, 
auto) but
would suggest that force land be the default.

also, there is a reason that the G1 doesnt auto-rotate due to accelerometer 
changes
in very many circumstances.  the auto-rotation on the iphone violates the 
"always do
the least surprising thing" principle.

all imho tho

Original comment by Jeffrey.Sharkey on 1 Nov 2008 at 6:23

GoogleCodeExporter commented 8 years ago
didnt hear back on this, so latest svn lets users choose between "force 
landscape",
"force portrait" and "auto" in their settings.  the default is "force 
landscape",
which follows from the 1.1 release, just so we dont surprise users.

Original comment by Jeffrey.Sharkey on 3 Nov 2008 at 2:24