search

ankurCES / meeting_facilitator_bot

A bot to run and facilitate meetings
MIT License
0 stars 2 forks source link

synthesize_speech on fixed input text #1

Open CloudApiStudy opened 4 years ago

CloudApiStudy commented 4 years ago

Hi,

I come from a research team which works on bugs in real-world applications.

I want to make a report about a few potential performance improvement in your project.

In file wake_up.py, synthesize_speech is called to generate audio files in each run. However, its input is a (or from a set of) fixed string. This behavior increases execution time and brings unnecessary service cost. A caching mechanism could help such situation, e.g. save audio file on disk at first API call, and re-use that file later.

Perhaps someone might be able to confirm if these seem reasonable. Also, if you need any help, I'm happy to provide some code snippet for fixing.

If you are not offended by it, we may include your response as a percentage number (e.g. xx% of applications faces xx problem, and xx% of them confirms it) in our research paper.

Thanks.

ankurCES commented 4 years ago

Thanks. Sure Please go ahead and include this.

Regards,

Ankur Nair

“DISCLAIMER: This email and any files transmitted with it are confidential and intended solely for the use of the individual or entity to which they are addressed. If you have received this email in error, please notify the sender. Please note that any views or opinions presented in this email are solely those of the author and do not necessarily represent those of the company. Finally, the recipient should check this email and any attachments for the presence of viruses. The company accepts no liability for any damage caused by any virus transmitted by this email.”

From: C Wan notifications@github.com Sent: Monday, August 17, 2020 5:54 PM To: ankurCES/meeting_facilitator_bot meeting_facilitator_bot@noreply.github.com Cc: Subscribed subscribed@noreply.github.com Subject: [ankurCES/meeting_facilitator_bot] synthesize_speech on fixed input text (#1)

Hi,

I come from a research team in University of Chicago, which works on bugs in real-world applications.

I want to make a report about a few potential performance improvement in your project.

In file wake_up.py, synthesize_speech is called to generate audio files in each run. However, its input is a (or from a set of) fixed string. This behavior increases execution time and brings unnecessary service cost. A caching mechanism could help such situation, e.g. save audio file on disk at first API call, and re-use that file later.

Perhaps someone might be able to confirm if these seem reasonable. Also, if you need any help, I'm happy to provide some code snippet for fixing.

If you are not offended by it, we may include your response as a percentage number (e.g. xx% of applications faces xx problem, and xx% of them confirms it) in our research paper.

Thanks.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/ankurCES/meeting_facilitator_bot/issues/1 , or unsubscribe https://github.com/notifications/unsubscribe-auth/ACCBCCYDQ3IGAGYOVK65DZ3SBEOMPANCNFSM4QBS2IWQ .