search

ankurdave / color-identifiers-mode

Emacs minor mode to highlight each source code identifier uniquely based on its name
308 stars 23 forks source link

Enable CI for pull-requests #114

Closed Hi-Angel closed 1 year ago

Hi-Angel commented 1 year ago

@ankurdave to continue this discussion, so, I did some tests on a test repo, and apparently making CI work requires enabling it in project settings. Here's what it looks like for my test project:

image

Can you please take a look at it?

ankurdave commented 1 year ago

CI would be great! It seems like the settings already defaulted to "allow", but I clicked Actions Permissions -> Save anyway just in case. Here's what I see:

Screen Shot 2023-04-05 at 9 12 25 AM
ankurdave commented 1 year ago

I clicked through the onboarding workflow in the Actions tab, which created a ci.yml file that seems to work. (I made some missteps first, sorry for the commit pollution.) I'm not sure why it didn't work in https://github.com/ankurdave/color-identifiers-mode/pull/113, but hopefully it should work now?

Hi-Angel commented 1 year ago

Oh, that sounds great, thank you! I'll experiment more with it this evening, thanks again!

Hi-Angel commented 1 year ago

Nice, thanks! Now it works, gotta figure out how to get an image with both ninja and Emacs — of these 3 the build system for some reason is only present in one image.

Hi-Angel commented 1 year ago

Hmm, FTR, apparently tests may fail on older Emacs releases because of this bug. Gotta think of a workaround or something…

Hi-Angel commented 1 year ago

It's interesting that Github has no button like "Merge when CI passed", like in Gitlab.

Anyway, now we have a working CI, yay!