search

ankurdave / color-identifiers-mode

Emacs minor mode to highlight each source code identifier uniquely based on its name
308 stars 23 forks source link

Keep colored syntax in unsupported modes #50

Closed Hi-Angel closed 6 years ago

Hi-Angel commented 7 years ago

It's usually unwanted to turn off syntax coloring in irrelevant modes, like markdown, html, other markup modes, unsupported langs…

The first 2 patches allows to limit turned off colors to supported modes. It should not cause regressions for those keeping to unset faces globally, because it's basically adding a hook, and a documentation change. I left so far in the commit the link to discussion behind empty string versus nil, I am unsure whether it's worth putting to a comment.

3-rd patch is irrelevant trivia.

Hi-Angel commented 6 years ago

@ankurdave for your interest, I am using the advice on the hook for long time already, the experience is great. E.g. at the moment I'm exploring some code and making remarks in markdown at the same time. I'm sure people would want to have their markup language highlighted whilst working with the code.

Hi-Angel commented 6 years ago

Any updates?

ankurdave commented 6 years ago

Thanks! Sorry to have ignored this for so long.