search

ankurdave / color-identifiers-mode

Emacs minor mode to highlight each source code identifier uniquely based on its name
308 stars 23 forks source link

Don't touch :box face rules on highlight identifiers #58

Open 11111000000 opened 6 years ago

11111000000 commented 6 years ago

Don't touch :box face rules on highlight identifiers

Hi-Angel commented 6 years ago

Minimal steps to reproduce would definitely help.

11111000000 commented 6 years ago

When :box faces used on some identifiers - color-identifiers-mode clear it

Hi-Angel commented 6 years ago

Minimal steps to reproduce would definitely help. FYI I never met those :box faces.

11111000000 commented 6 years ago

I think, simply we need

(add-face-text-property start end `(:foreground ,hex) t)

instead of put-text-property in color-identifiers:colorize

ankurdave commented 6 years ago

Hmm, that change makes sense but somehow seems to break coloring for most identifiers.