ankurhanda / gvnn

gvnn: Geometric Vision with Neural Networks
445 stars 71 forks source link

A bug in derivatives derivation? #10

Open Ignotus opened 7 years ago

Ignotus commented 7 years ago

Hello,

There seems to be a small issue for derivatives near identity. A multiplication with a Rotation matrix should be applied only when omega_mag > threshold, for another case since:

R = I + w_x

A partial derivative will be just:

\partial{R}{\partial w_i} = G_i

where G_i is a generator matrix for the i-th element (Section 3.3 Gallego et al. (2014)).

Best Regards,

Minh