bug fix in Opticalflow: earlier the image was getting transposed

ankurhanda / gvnn

gvnn: Geometric Vision with Neural Networks

445 stars 71 forks source link

bug fix in Opticalflow: earlier the image was getting transposed #16

Closed ruppeshnalwaya1993 closed 7 years ago

ruppeshnalwaya1993 commented 7 years ago

I think there is a Bug in Opticalflow2D. The image after applying the optical flow using BilinearSamplerBHWD is transposed (x and y axes interchanged). The reason being error in self.baseGrid calculation. I have updated that. Please review.

Thanks Ruppesh

ankurhanda commented 7 years ago

It isn't a bug. I also provided ReverseXY layer https://github.com/ankurhanda/gvnn/blob/master/ReverseXYOrder.lua. This was mainly done because interpolations expected something that my other layers like so3/se3 etc. didn't quiet order the data the same way. If you are happy with it then that's fine. I will probably update the README.md and explain that.