search

ankurhanda / gvnn

gvnn: Geometric Vision with Neural Networks
445 stars 71 forks source link

Limitation value #27

Closed HTLife closed 6 years ago

HTLife commented 6 years ago

The limit of one_minus_cos_div_theta_sqr is 0.5. Should this line be 0.5?

From

one_minus_cos_div_theta_sqr_tensor[b] = one_minus_cos_div_theta_sqr_tensor[b]:fill(0)

to

one_minus_cos_div_theta_sqr_tensor[b] = one_minus_cos_div_theta_sqr_tensor[b]:fill(0.5)
ankurhanda commented 6 years ago

it is not 0.5 I'm sure it is 0.

HTLife commented 6 years ago

Did I prove it wrongly? _062818_084642_am

ankurhanda commented 6 years ago

There is omega^2 as well which is multiplied to it.

HTLife commented 6 years ago

I got your intention here.