search

ankurk91 / google-chat-electron

An unofficial desktop app for Google Chat :electron:
GNU General Public License v3.0
162 stars 49 forks source link

Feature request: File downloads from within App #19

Closed vincentrozenberg closed 2 years ago

vincentrozenberg commented 3 years ago

It would be great if the Google Meet window opens inside the app, or alternatively, as a popup in the app. Also file downloads; Now both the meet and file links opens a browser, which specifically is inconvenient if you use different accounts (let's say, Browser is defaulting to Account A, and Google-Chat-Electron is set to a different Google/Workspace account, the files and links open in the browser with the wrong user, and with the files it even prompts a 404).

ankurk91 commented 3 years ago

Great idea, but does electron can handle the file download well?

vincentrozenberg commented 3 years ago

Great idea, but does electron can handle the file download well?

I assume it does; I guess it is a matter of "catching" the "https://chat.google.com/u/0/api/get_attachment_url?" url, before it directs to the browser. Or a different way, via the "download link" in previews: image

vincentrozenberg commented 3 years ago

Actually what i mean is, that it "saves to disk" via the app, not via the browser

ankurk91 commented 3 years ago

I am already catching the download file URL and sending it to external browser. https://github.com/ankurk91/google-chat-electron/blob/master/src/main/features/externalLinks.ts#L36

I can plan to download the files within the app, but having the google meet within the app requires too much efforts and testing. I can imagine people will ask for whole google suite products to work inside this app. :laughing:

I don't see myself free enough for any big feature before Jan 2022. :)

vincentrozenberg commented 3 years ago

Thanks for looking into it!

ankurk91 commented 2 years ago

It has been more than 1 year since this issue, I could not find enough time to work on this.