search

ankurk91 / google-chat-electron

An unofficial desktop app for Google Chat :electron:
GNU General Public License v3.0
162 stars 49 forks source link

Feature Request: Dark Mode #20

Closed kylegrieder closed 3 years ago

kylegrieder commented 3 years ago

Besides the fact that the PWA is absolutely terrible, the other thing I really dislike about it (as opposed to the mobile apps) is the lack of a dark mode. I've tried injecting CSS via Stylus or other means, but the way the PWA classes are set up, it's quite difficult. A dark mode would be nice, so it matches the rest of my applications. I might actually do this myself, and submit a PR for it, just wanted to put it here as well.

ankurk91 commented 3 years ago

Dark mode is already there, but is upto user choice.

Check the app menus, and enable the dark mode. Restart the app to apply.

kylegrieder commented 3 years ago

OH! I was looking at the menus in-app, I didn't look at the macos system menus. thanks!

kylegrieder commented 3 years ago

although... the dark mode is less than ideal. CleanShot 2021-08-09 at 10 16 52@2x

ankurk91 commented 3 years ago

What is your app version?

Are you using the latest version of the app?

kylegrieder commented 3 years ago

I just downloaded it today, app version 2.5.1

ankurk91 commented 3 years ago

I will check the dark mode on my vm machine tomorrow and report back here.

BTW, we are using dark reader Chrome extension behind the scene.

The app auto downloads the extension from Chrome store and start using it.

https://github.com/darkreader/darkreader

kylegrieder commented 3 years ago

I checked that out. Installed the extension to Chrome and loaded the PWA. Got the same result.

Although what is really interesting is I used CMD + R to reload this app (google-chat-electron) and now I'm getting complete dark mode: CleanShot 2021-08-09 at 11 08 36@2x

ankurk91 commented 3 years ago

Great news, Chrome extension are experimental in electron apps.

I am closing the issue now.

kylegrieder commented 3 years ago

Sounds good. thanks again for making this, really enjoying it so far.