search

ankurk91 / google-chat-electron

An unofficial desktop app for Google Chat :electron:
GNU General Public License v3.0
162 stars 49 forks source link

[mac] Update App Name #70

Closed AdamCoulterOz closed 2 years ago

AdamCoulterOz commented 2 years ago

Can you please rename it so it doesn't show as "google-chat-electron" in the UI? Maybe to "Google Chat"?

Screen Shot 2022-03-07 at 12 10 09 pm Screen Shot 2022-03-07 at 12 10 13 pm
ankurk91 commented 2 years ago

If it was easy, I would have done this before.

We need to target 3 different platforms. It is not easy.

Note : I am not using electron-forge or similar for building the installers.

P.S. - electron packager can take appname in command

npx electron-packager <sourcedir> <appname> --platform=<platform> --arch=<arch> [optional flags...]
ankurk91 commented 2 years ago

This will break existing installation, since the app name will be changed.

It is too late to change the app name :(

AdamCoulterOz commented 2 years ago

It really isn't. Just have it check for multiple existing file names.