ankurk91 / vue-loading-overlay

Vue.js component for full screen loading indicator :cyclone:
https://ankurk91.github.io/vue-loading-overlay/
MIT License
1.25k stars 102 forks source link

fix css #44

Closed connectnew closed 4 years ago

connectnew commented 4 years ago

First line in css file must empty or use for comment, because if it’s not, then when you use lazy loading and the webpack it breaks the styles.

webpackContext.id = "./node_modules/moment/locale sync recursive ^\\.\\/.*$";.vld-overlay {
  bottom: 0;
  left: 0;
  position: absolute;
  right: 0;
  top: 0;
  -webkit-box-align: center;
          align-items: center;
  display: none;
  -webkit-box-pack: center;
          justify-content: center;
  overflow: hidden;
  z-index: 1
}
ankurk91 commented 4 years ago

@connectnew Hi, i could not understand this, how can i re-produce this issue?

Can you show me an example of other similar package which has empty line in css?

ankurk91 commented 4 years ago

@connectnew what about having a banner

https://webpack.js.org/plugins/banner-plugin/

ankurk91 commented 4 years ago

@connectnew I have added a banner in output css file, it should be fixed in next release

connectnew commented 4 years ago

Hi, sorry for late response, thank you.

сб, 29 февр. 2020 г. в 16:23, Ankur Kumar notifications@github.com:

@connectnew https://github.com/connectnew I have added a banner in output css file, it should be fixed in next release

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ankurk91/vue-loading-overlay/pull/44?email_source=notifications&email_token=ADEEJGH35E4FC2OGZWVLY33RFEM4JA5CNFSM4KXGIRBKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENL3JLQ#issuecomment-592950446, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADEEJGEXPNOY5EPOWDQ67ZTRFEM4JANCNFSM4KXGIRBA .