search

ankurk91 / vue-trumbowyg

Vue.js component for Trumbowyg WYSIWYG editor :memo:
https://ankurk91.github.io/vue-trumbowyg/
MIT License
236 stars 35 forks source link

jquery dependency fails #24

Closed ghost closed 5 years ago

ghost commented 5 years ago

Jquery dep is not specified in package.json but plugin looks for it and can't find.

ankurk91 commented 5 years ago

Already specified in readme.

https://github.com/ankurk91/vue-trumbowyg/blob/master/README.md#requirements

And here https://github.com/ankurk91/vue-trumbowyg/blob/1058f9d3d34064e8170147fb0da7bb7cfbc92975/package.json#L60

And here

https://alex-d.github.io/Trumbowyg/documentation/

I wish if I could specify "Google Chrome" in package.json because the package requires a browser too.

ghost commented 5 years ago

It is your dependency, you should define it in your package

ankurk91 commented 5 years ago

I have not specified vue as well. But I can think about specifying jquery.

ghost commented 5 years ago

Did you just write about Chrome as a dependency. I wonder how my email updated as well. And if, what changed your mind?

ankurk91 commented 5 years ago

It is morning time here in India. ;) Don't worry, will get a new version today with jQuery as a dependency.

ghost commented 5 years ago

Out of curiosity. The question is; Does gmail updates github comments?

ankurk91 commented 5 years ago

You can reply to the email thread and it will be posted here as a comment.

ghost commented 5 years ago

Nice to know. Thanks.

ankurk91 commented 5 years ago

published v3.4.2