search

ankurpiyush26 / pubsubhubbub

Automatically exported from code.google.com/p/pubsubhubbub
Other
1 stars 0 forks source link

Callback URLs should allow query strings, should have Hub params added to them #25

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
SUMMARY:

> hub.callback now "should not" contain query-string or fragment: no fragment
> makes sense (well, if my limited understanding of URL semantics is right),
> but why not permit query-strings? (I would, instead, require hubs to respect
> any potentially existing query-strings when adding parameters to the
> callback URL)

RELEVANT SECTION:  6.1

COMMENT/REQUEST:

We should respect query strings!

Original issue reported on code.google.com by bslatkin on 14 Jul 2009 at 4:59

GoogleCodeExporter commented 9 years ago

Original comment by bslatkin on 27 Aug 2009 at 3:02

GoogleCodeExporter commented 9 years ago 
Addressed in 0.2

Original comment by bslatkin on 2 Sep 2009 at 1:21

GoogleCodeExporter commented 9 years ago 
Does the reference hub actually do this though? Looking at 
confirm_subscription, I see:

parsed_url = list(urlparse.urlparse(utf8encoded(callback)))
...
parsed_url[4] = urllib.urlencode(params)
adjusted_url = urlparse.urlunparse(parsed_url)

So it looks like query params are replaced in the callback url (during 
verification only, they're preserved for 
subscriptions).

Original comment by mihai.parparita on 11 Oct 2009 at 2:16

GoogleCodeExporter commented 9 years ago 
Hey Mihai, sorry this issue was just for fixing the issue in the spec document
itself; I haven't finished updated the hub implementation to do this properly 
cuz
I've been frying bigger fish. Thanks for the poke. I've filed
http://code.google.com/p/pubsubhubbub/issues/detail?id=88 to track this.

Original comment by bslatkin on 11 Oct 2009 at 6:43