search

ankurpiyush26 / pubsubhubbub

Automatically exported from code.google.com/p/pubsubhubbub
Other
1 stars 0 forks source link

find_feeds_update should rely on <updated> instead of sha1 diff #85

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 

A lot of feed will make insignificant updates to their entries but keep the
<updated> tag the same:

$ grep update 1 2
1:<updated>2009-10-04T05:19:39Z</updated>
2:<updated>2009-10-04T05:19:39Z</updated>

But the sha1 signature will differ because of innocuous changes. This
happens for friendfeed and many other feeds... the hub will keep on trying
to deliver these items: 

--- 1   2009-10-04 12:44:25.000000000 +0700
+++ 2   2009-10-04 12:44:09.000000000 +0700
@@ -28,7 +28,7 @@

 <div style="margin-top:2px; color:#737373; font-size:10pt">
-<a
href="http://friendfeed.com/kugutsumen/5390b6ba/gran-turismo-5-is-going-to-suppo
rt-damage-i-ll"
style="color:#737373; text-decoration:none">21 minutes ago</a>
+<a
href="http://friendfeed.com/kugutsumen/5390b6ba/gran-turismo-5-is-going-to-suppo
rt-damage-i-ll"
style="color:#737373; text-decoration:none">14 minutes ago</a>

 from <a style="color:#737373; text-decoration:none" rel="nofollow"
href="http://twitter.com/kugutsumen/statuses/4596915766">Twitter</a>

Original issue reported on code.google.com by kugutsu...@gmail.com on 4 Oct 2009 at 5:47

GoogleCodeExporter commented 9 years ago 
Yep. That's how it goes. What's actually wrong here? In theory, the feed 
changing
should only be accompanied by a ping from the publisher when the publisher 
thinks
it's significant, so these changes should be kept to a minimum. However, it 
does mean
redelivery to subscribers when these insignificant changes are made.

Original comment by bslatkin on 5 Oct 2009 at 6:48

GoogleCodeExporter commented 9 years ago 
When the demo hub is polling, it ignores the updated tag and think the entry is 
new every time the sha1 digest 
changes. It will keep trying to deliver the same feed entries over and over 
again for several days. 

That's the case with friendfeed and few other sources.

Original comment by kugutsu...@gmail.com on 5 Oct 2009 at 8:49

GoogleCodeExporter commented 9 years ago

Original comment by bslatkin on 6 Jun 2010 at 2:21

GoogleCodeExporter commented 9 years ago 
http:/ttp://oracoesjbm.blogsot.com.br/2014/07/blog-post.html#comment-form

Original comment by crimoore@gmail.com on 19 Jul 2014 at 9:13