search

ankurrsinghal / svelte-legos

A framework for Svelte Utilities 💡 Current status: 87 utilities.
https://svelte-legos.surge.sh
MIT License
778 stars 27 forks source link

Upgrade to svelte 4 #100

Closed devcsrj closed 1 year ago

devcsrj commented 1 year ago

When installing, npm will complain with:

npm ERR! Found: svelte@4.1.2
npm ERR! node_modules/svelte
npm ERR!   dev svelte@"^4.1.2" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer svelte@"^3.54.0" from svelte-legos@0.2.1
npm ERR! node_modules/svelte-legos
npm ERR!   dev svelte-legos@"*" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR!
LeoCaprile commented 1 year ago

@ankurrsinghal Hey I came back, was looking trough the docs and seen this guide: https://svelte.dev/docs/v4-migration-guide I would make a try to migrate the library, and if I success, I'll open the MR. Thanks for opening this issue! @devcsrj

LeoCaprile commented 1 year ago

I checked, it is already updated.

devcsrj commented 1 year ago

Looks like its been addressed by https://github.com/ankurrsinghal/svelte-legos/pull/91/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519R74