search

ankushbhardwxj / codemon

cli to win programming contests
https://pypi.org/project/codemon/
MIT License
26 stars 12 forks source link

breaking down the components of the project. #20

Closed yashshah14093 closed 3 years ago

yashshah14093 commented 3 years ago

Divided the functions into a different set of python scripts, So that it would be easier for further development.

ankushbhardwxj commented 3 years ago

@yashshah14093 - Hey, I can merge the PR but you will not be awarded points for it because contribution starts from Dec 1. Make this PR again on Dec 1 if you want points .

yashshah14093 commented 3 years ago

@yashshah14093 - Hey, I can merge the PR but you will not be awarded points for it because contribution starts from Dec 1. Make this PR again on Dec 1 if you want points.

It would be great if you merge this PR as further development in this project will be easier. I have no issue with the points.

yashshah14093 commented 3 years ago

Made all the changes except one that is not resolved.

yashshah14093 commented 3 years ago

@yashshah14093 - Made some more comments.

  • Remove the extra newlines in between the code. It's quite readable. If you want to improve code quality or readability, there are other ways to do that which is by refactoring some already written code.
  • Make sure the tab size on all pages is 2 and tabs are converted to spaces.

Made all the changes in the application.

yashshah14093 commented 3 years ago

One last thing, could you get rid of that binary at __pycache__ ?

Can I add that file to .gitignore?

ankushbhardwxj commented 3 years ago

Can I add that file to .gitignore?

Yeah sure & also remove it from this PR with a new commit.

ankushbhardwxj commented 3 years ago

Please resolve the conflicts. For reference see the changes made in #26

yashshah14093 commented 3 years ago

Added the pycache to .gitignore and also resolved the conflicts by updating the changes.

ankushbhardwxj commented 3 years ago

LGTM ! Thanks @yashshah14093 !