Fixed the issue of compilation in case of windows OS

ankushbhardwxj / codemon

cli to win programming contests

https://pypi.org/project/codemon/

MIT License

26 stars 12 forks source link

Fixed the issue of compilation in case of windows OS #31

Closed lucifer0987 closed 3 years ago

lucifer0987 commented 3 years ago

Things changed :

Earlier, the fix which was merged wasn't able to account for whitespaces and created an error when the directory contained a whitespace. More info about the issue here : https://github.com/ankingcodes/codemon/issues/21#issuecomment-736617735

ankushbhardwxj commented 3 years ago

@paramsiddharth - Does the issue you created at #33 fix this ?

lucifer0987 commented 3 years ago

@ankingcodes Till @paramsiddharth fixes this issue, I won't be able to work on any other issue. Because currently, the programs don't compile on my system because of whitespace error. So, if it would be easier for me if @paramsiddharth fixes #33 asap or you merge this PR. Whatever works for you.

ankushbhardwxj commented 3 years ago

@lucifer0987 - Check #33, Param has presented a nice alternative to your PR.

I won't be able to work on any other issue.

Try using WSL or a UNIX terminal, its working fine there.

paramsiddharth commented 3 years ago

@paramsiddharth - Does the issue you created at #33 fix this ?

Yes, it certainly does. That is one of the most important reasons to use subprocess instead of os.system.

lucifer0987 commented 3 years ago

@ankingcodes yeah, that's the issue. I don't have UNIX or WSL terminal. I will wait for @paramsiddharth then.