Codemon reg - Githubissues

ankushbhardwxj / codemon

cli to win programming contests

https://pypi.org/project/codemon/

MIT License

26 stars 12 forks source link

Codemon reg #54

Closed lucifer0987 closed 3 years ago

lucifer0987 commented 3 years ago

closes :- #15 Added codemon reg. Asks for user details when this command is used. meta file is stored at project root.

lucifer0987 commented 3 years ago

@ankingcodes I have made changes. please review. Also, how can I add tests to this. I have never worked on adding tests, so it would be great if you could guide me a little here.

lucifer0987 commented 3 years ago

@ankingcodes updated code as you requested. Please review.

ankushbhardwxj commented 3 years ago

@lucifer0987 - Looks good ! One last change.

lucifer0987 commented 3 years ago

@ankingcodes made changes, please review.

lucifer0987 commented 3 years ago

@ankingcodes made changes as you suggested. I hope this time it gets merged. I made so many silly mistakes. fingers crossed!

ankushbhardwxj commented 3 years ago

@lucifer0987 - There are two more issues here:

Validation of inputs given as username and password. Right now empty username and passwords are saved on meta.json
Validation to check if meta.json already exists at .codemon/. Right now codemon reg overwrites the meta.json file without any warning.

I wont force on doing these on this PR, but you may create an issue on them for some bonus points.

ankushbhardwxj commented 3 years ago

@lucifer0987 - This PR looks great ! Thanks !

lucifer0987 commented 3 years ago

@ankingcodes yeah sure. Thanks! 👍