ankushbhardwxj / typecoder

monkeytype "for developers". 💥
https://typecoder.netlify.app
13 stars 10 forks source link

SignIn form #7

Closed ankushbhardwxj closed 3 years ago

ankushbhardwxj commented 3 years ago

NOTE: (For NWOC students)- Each of the issues can be treated as individual issues for which points would be given accordingly.

pankajkumarbij commented 3 years ago

Hello I would like to contribute to the first issue(passwords are not encrypted using jwt on signup. Add jwt encryption on signup and use bcrypt for signin).

luckykumarirai commented 3 years ago

Hello I would like to contribute to the issue(Add validations for various fields on the Signup / Signin form. Use semantic-UI label pointers to show user for incorrect input (beginner))

ankushbhardwxj commented 3 years ago

@pankajkumarbij - Hi ! Go ahead and send me a PR on it. I'll be happy to review ! @luckykumarirai - Go ahead with making the PR 👍🏻 !

pankajkumarbij commented 3 years ago

Hello I have sent a PR on the first issue(password encryption) please review it.

Sensrdt commented 3 years ago

Hi! Can I work on the third and fifth issues?

ankushbhardwxj commented 3 years ago

@Sensrdt - Hello, go ahead and submit a PR !

Sensrdt commented 3 years ago

@ankingcodes What should be the username and password for google signin user ?

ankushbhardwxj commented 3 years ago

@Sensrdt - Could you create one for yourself while making the PR ? I'll change it with mine later. Use a config directory which contains a keys.js file where you can store the clientId, and clientsecret.

luckykumarirai commented 3 years ago

Hello I have sent a PR on the second issue(form validation) please review it.