search

ankushgarg1998 / ipu-ranklist

:chart_with_upwards_trend: A minimalist result & ranklist application for IP University (GGSIPU) folks. All results starting 2015.
https://ipuranklist.com/
116 stars 15 forks source link

Wrong Subject Name #130

Closed gauravjain2 closed 1 month ago

gauravjain2 commented 2 years ago

Hi For subject code HS-402 for USICT B.Tech 8th Semester, the actual subject name is "Technical Writing", but it is showing "Human Values and Professional Ethics II" Please update the same.

ankushgarg1998 commented 2 years ago

Hey @gauravjain2 Let me check. Could you share the paperID as well?

Could be a case of #87

gauravjain2 commented 1 year ago

Hi @ankushgarg1998 , the paperID is 98402 and the subject code is HS-402. Yeah, it might be a case of #87

Subject: Technical Writing paperID: 98402 subjectCode: HS-402

Subject: Human Values and Professional Ethics II paperID: 98402 subjectCode: ETHS-402

Observation: To add on, despite having the same paperID, both subjects have an entirely different syllabus.

I think, you have made paperID as primary key in the Database, you can probably go with the combination of paperID and subjectCode as the primary key

ankushgarg1998 commented 1 year ago

Agreed @gauravjain2

It needs to be a composite index: Either (paperId, subjectCode) OR (paperId, admissionYear).

Need to find data & examples to make a judicious choice between these two.

gauravjain2 commented 1 year ago

The admission year might not work. Because in same admission year (like in the present case) we had same I'd. I'll check a few other corner cases around this issue and will get back to you.

On Sat, 8 Oct 2022, 8:18 pm Ankush Garg, @.***> wrote:

Agreed @gauravjain2 https://github.com/gauravjain2

It needs to be a composite index: Either (paperId, subjectCode) OR (paperId, admissionYear).

Need to find data & examples to make a judicious choice between these two.

— Reply to this email directly, view it on GitHub https://github.com/ankushgarg1998/ipu-ranklist/issues/130#issuecomment-1272335819 , You are receiving this because you were mentioned.Message ID: @.***>

ankushgarg1998 commented 1 year ago

Oh is it? Are these two subjects of the same batch but different semesters?

Thanks. Please do. It'll be very helpful.

ankushgarg1998 commented 1 year ago

Hi @gauravjain2 Were you able to check this? I was thinking of building a solution around this, over this long weekend.

ankushgarg1998 commented 1 month ago

Hi @gauravjain2

This fix for this issue has been deployed. ✅ Please verify. Thanks.