search

anlarke / MovieExplorer

View information about the movies stored on your computer. (Windows)
48 stars 24 forks source link

Fixed vs2013 compatibility with cmath. Play and Directory Button Changes #1

Closed ryanjay0 closed 10 years ago

ryanjay0 commented 10 years ago
is deprecated in c++ and won't compile in VS2013. Changed to Play button now handles directories differently. It looks in the directory for the first file without the word sample in it that has one of the extensions listed in the options by the user. It plays this file or just opens the directory if no file is found. Directory button now opens the directory the movie is in. It won't handle cases where the movie is nested deeper like CD1/CD2. VS2013 made some tiny changes to the project files. I didn't want to create a new file. I'm not sure if its back compatible with VS2010, making the VS2010 directory name outdated.
anlarke commented 10 years ago

Please create a new folder called VS2013, I'd still like to use the VS2010 folder (not planning to switch yet).

Also I have some comments on your code:

  1. Please confirm to the (semi-Hungarian) notation that is already used in the project. Yes I know it's outdated, for new projects I don't use it either. But keep it uniform okay. This also holds for the comments, please keep an empty line above and below them.
  2. In your added code in MovieExplorer\ListView.cpp there is no need to use bIndexDirs. You'd typically don't want to include directories when calling EnumFiles. Therefore the third parameter can be omitted (as it defaults to false).