search

anlutro / botologist

Plugin-driven Python3 IRC
MIT License
5 stars 5 forks source link

Dota, wew #69

Closed x89 closed 8 years ago

anlutro commented 8 years ago

WTF is with all these unrelated commits?

Re-commit the dota plugin on a new branch based on master and I'll merge it

moopie commented 8 years ago

@anlutro this is how dictatorship looks like

x89 commented 8 years ago

Pls @anlutro

anlutro commented 8 years ago

Only use ASCII in the YAML config, please.

There's a requirements.txt in the root directory, use that one.

Get that *.swp out of the gitignore. It belongs in your global gitignore.

22 commits WTF? Squash them please.

anlutro commented 8 years ago

Also can't we make a way for people to assign DOTA IDs to names through an IRC command? Hard-coding it in the plugin module is the worst possible solution.

x89 commented 8 years ago

Why only ASCII in the YAML example?

Requirements is gone, idk how that got there and you have a point on the *.swp, I'll take that out.

Why squash the commits? They're history!

And the reason for not implementing dynamic Dota IDs is because a proper backing storage for that would be a database, which is beyond the scope of what's necessary for 2-3 players. I could compromise and put it into the config file as well but that's a very half-way measure.

anlutro commented 8 years ago

History is nice but in your case it's just useless noise. Like this one https://github.com/anlutro/botologist/pull/69/commits/39b66d58156b4cbb13bdaf14d33371c4f3569d12

Certain YAML loaders only accept ASCII for compatibility reasons.. Same reason as only using ASCII in python source files I suppose. But on the other hand, IRC channel names allow unicode characters, which means you'd have to put unicode characters into the YAML anyway, so never mind that.

anlutro commented 8 years ago

You could do what I've done with the streams plugin, just write a simple state to a JSON file. A proper database (redis or something) would obviously be better but a file works fine.