anlutro / laravel-4-smart-errors

Smarter error handling for Laravel 4
65 stars 13 forks source link

Laravel 5 #24

Open anlutro opened 9 years ago

anlutro commented 9 years ago

Laravel 5 has stripped out the error handling features that made this package work out of the box.

Options:

Additionally, config namespacing has been removed, so that will need to be reworked.

bartjuh4 commented 9 years ago

Maybe this package can help:

https://github.com/morrislaptop/LaravelFivePackageBridges

This weekend i will give it a try and share my results.

Update: I forked the repository and started changing bits of code to work with L5 and i think i have almost every functionality working as with L4. Can you check my fork or do i have to make a pull request? (git newbie)

https://github.com/anlutro/laravel-4-smart-errors/compare/master...Bartjuh4:master

anlutro commented 9 years ago

Thanks for your initial work on this - it's very useful.

I won't follow the same approach - I don't want to maintain two different versions of the library for different Laravel versions, so I'll have to add some extra code to provide compatibility between the versions.

bartjuh4 commented 9 years ago

Okay, maybe i could help you with that. The goal to get this package working for L4 as wel as L5 would be great. The only change (in my opinion) that may be needed at this moment would be a switch in the serviceprovider for L4/L5.

anlutro commented 9 years ago

Indeed. The initial work I did is on the develop branch if you're interested.

I just need to decide how to do the ErrorHandler class really. The report() and render() stuff really doesn't fit with my model of how errors should be managed, so I need to think about it.