search

anlutro / laravel-4-smart-errors

Smarter error handling for Laravel 4
65 stars 13 forks source link

Treat MethodNotAllowedHttpException the same as NotFoundHttpException? #31

Open 501st-alpha1 opened 8 years ago

501st-alpha1 commented 8 years ago

I've noticed that MethodNotAllowedHttpExceptions are usually not caused by bugs in the code, but are harmless user errors. (Or more often, triggered by spam or indexing bots.)

The README says:

404 errors are written in the log as warnings with the URL accessed + referrer [and no notification emails are sent]

I think it could be useful to do the same for wrong-method errors.

I also saw this:

If you want to handle specific types of exceptions yourself, you can add App::error closures with those specific exceptions as arguments. Exceptions handled using App::error will not be e-mailed or logged by this package.

and I can do that instead, but I though this might be something the package could handle.

Thoughts? If you'd like to do this, I can probably send another PR.

anlutro commented 8 years ago

I think this would be a good idea. However, I know that I personally would like to keep getting email notifications about these errors, so it would have to be configurable.