Allow this to work in Laravel 4.2 on PHP 7

anlutro / laravel-4-smart-errors

Smarter error handling for Laravel 4

65 stars 13 forks source link

Allow this to work in Laravel 4.2 on PHP 7 #34

Closed JayBizzle closed 7 years ago

JayBizzle commented 7 years ago

This will allow this package to work correctly on PHP 7.

Ideally, Exception would be changed to Throwable, but that wouldn't be backwards compatible, and as this package hasn't been actively developed for a while, I thought this quick fix would be the best solution.

Thanks

anlutro commented 7 years ago

Hey, thanks. I'm going to do a bit of work to make the tests work on PHP7 before merging this in.

anlutro commented 7 years ago

Hey, could you rebase your patch-1 branch against this repository's master branch?

git remote add upstream https://github.com/anlutro/laravel-4-smart-errors
git update
git rebase upstream/master
git push -f

JayBizzle commented 7 years ago

No worries, will try and sort that this evening or tomorrow. Thanks

JayBizzle commented 7 years ago

Okay, rebase done and tests now all green 👍