Fix retrieval of incorrect keys when numeric keys are stored and fetched using SettingsStore::all(). Usage of array_merge in SettingsStore::load() causes the numeric keys in the resultant array to be renumbered. Using + operator to merge two arrays with numeric keys should be a safer option.
Tests:
Testing started at 4:53 pm ...
PHPUnit 8.5.30 #StandWithUkraine
Time: 164 ms, Memory: 10.00 MB
OK (65 tests, 117 assertions)
Process finished with exit code 0
Fix retrieval of incorrect keys when numeric keys are stored and fetched using
SettingsStore::all()
. Usage ofarray_merge
inSettingsStore::load()
causes the numeric keys in the resultant array to be renumbered. Using+
operator to merge two arrays with numeric keys should be a safer option.Tests: