Closed GoogleCodeExporter closed 9 years ago
I am attaching patches porting the Chromium fix as patches to Chromium code,
for CEF branches 1453 and 1547
Original comment by ol...@adobe.com
on 22 Jul 2013 at 10:20
Attachments:
Issue 1025 has been merged into this issue.
Original comment by magreenb...@gmail.com
on 22 Jul 2013 at 4:11
Thanks, added in 1547 branch revision 1326 and 1453 branch revision 1327 with
minor naming changes.
Original comment by magreenb...@gmail.com
on 22 Jul 2013 at 5:06
@olaru: I have some users reporting this crash on 10.7.2. I think we need to
update these patches to check for the OS-X patch version. Were you able to
determine a good way to do this? Thanks.
Original comment by magreenb...@gmail.com
on 25 Jul 2013 at 6:08
I have described a possible fix on the Chromium issue:
https://code.google.com/p/chromium/issues/detail?id=260595
I haven't tested it on 10.7.2 in any way yet. I think I need to set up a 10.7.2
somewhere, because I don't have one available.
Original comment by ol...@adobe.com
on 25 Jul 2013 at 9:52
The code for fixing 10.7-10.7.2 is in review with Chromium and should make it
in trunk soon. I will create patches for the CEF branches after I address the
comments.
Original comment by ol...@adobe.com
on 29 Jul 2013 at 5:54
Adding the fixes for 10.7 crashes on CEF branches. The patches contain the code
as resulting from this review:
https://codereview.chromium.org/21088004/
There are patches that apply directly on a CEF checkout - patches to the
Chromium patches. These end in patchDiff.
I am also attaching the Chromium patches, for simpler reviewing, which can be
copied on top of the files in patch/patches.
Original comment by ol...@adobe.com
on 30 Jul 2013 at 1:34
Attachments:
@comment#7: Thanks, added in 1453 branch revision 1351 and 1547 branch revision
1352 with minor changes.
Original comment by magreenb...@gmail.com
on 30 Jul 2013 at 3:49
The fix has been submitted in Chromium trunk r 212060.
Original comment by ol...@adobe.com
on 1 Aug 2013 at 7:35
Original issue reported on code.google.com by
ol...@adobe.com
on 22 Jul 2013 at 10:19