Redistribute Promos

[anmart]

The following is a list of Promo sources, copied from Bulbapedia. Bolded entries have been added to the randomizer

• Arcanine - Trade Lapras at the Water Club
• Moltres - Beat the game
• Articuno - Beat the game
• Pikachu - Trade Clefairy at the Grass Club
• Pikachu - Trade five uncommon cards at the Fighting Club
• Flying Pikachu - Trade Ditto with Mr. Ishihara
• Surfing Pikachu - Trade Clefable with Mr. Ishihara
• Surfing Pikachu - Trade Chansey with Mr. Ishihara
• Electabuzz - Trade Electabuzz at the Lightning Club
• Zapdos - Beat the game
• Slowpoke - Trade any unused Energy cards at the Fire Club
• Mewtwo - Win the Challenge Cup once after obtaining the third Master Medal
• Mewtwo - Talk to Pappy at the Psychic Club lounge and come back after defeating Club Master Murray
• Mew - Win the Challenge Cup a second time after obtaining the sixth Master Medal
• Jigglypuff - Defeat Ronald after obtaining the second Master Medal
• Dragonite - Beat the Pokemon Dome
• Imakuni? - Defeat Imakuni? three times
• Super Energy Retrieval - Defeat Ronald after obtaining the fifth Master Medal
• Venusaur - Card Pop! (Note: Add a new source for this)
• Mew - Card Pop! (Note: Add a new source for this)

---

Right now when you defeat Ronald/Beat the dome, you'll be given the same promotional cards.

There are two ways to do this:

• Track down all of the scripts that give cards and change them there
• Change it at the source: 3:4f4c in the TCG code is the function responsible for giving out the cards, and it has the option to load a card from memory instead of from the script's argument. If this is hooked into, we could give any arbitrary card we'd like.

If every instance of the give card script is found, it would be better to do method 1 as there's no code patching involved. If the second one, it would require less effort in script reversing, but would require that we either give a random card (different each time you play) or determine where the script was called from and give the card based on that -- Which wouldn't even be much easier. Either way also requires a relatively involved romhack that could interfere with other hacks very easily.

[anmart]

This issue has been changed to keep track of the Promo cards that need to be moved around in the randomizer. The goal is to ensure that every card is obtainable so an All Cards run can be done. Not sure on how to handle the 2 "Phantom rares" yet.

33b95ba8a7e9e08f3a3446f7d0d753c930bc6f9c Started addressing this by allowing you to choose whether you want to randomize promos at all

[anmart]

cd2cfc8 introduced the first trade promo. Thinking about allowing you to randomize though. Should they be linked somehow? would require some new stuff.

The text requires being changed too, not sure how we could tackle that. might be an issue for later.

[anmart]

As if ff7c0a0 there is a new issue - The text saying what pokemon is received is stored in other places because you can get these cards randomly from refacing the dome. Need to think hard about how text can be changed.

[anmart]

Func_1a61f Handles hardcoded names for trades. It seems like it only does it for a few specific ones, anything else can manually do it. I have no idea why. But it's necessary that trades also change those.

[anmart]

The Lass in grass club lobby has 2 more trades than just the promo - include that in rando?