anmode / grabtern-frontend

Connecting the mentors and creating a network
https://grabtern.in/
MIT License
26 stars 52 forks source link

🚀 [Feature Request] - Transition to new HomePage #442

Closed anmode closed 1 year ago

anmode commented 1 year ago

Is your feature request related to a problem ? Please describe. ✍️

We will be moving to the new HomePage... new theme is: https://grabtern-new-frontend.vercel.app/ ( light theme)

source code you can take help : https://github.com/anmode/grabtern-NewFrontend ( tailwind classes are there you can copy directly) Our theme color new is #845ec2 Remember background should not be pure white* See the new theme

Describe briefly how you would implement this enhancement.

Null

Additional context or screenshots

Additional context

Are you contributing for a program?

GSSoC2023

Code of Conduct

anmode commented 1 year ago

This PR: https://github.com/anmode/grabtern-frontend/pull/328 ( hero section) This PR:https://github.com/anmode/grabtern-frontend/pull/372 ( Nav) This pR: https://github.com/anmode/grabtern-frontend/issues/403 ( testimonial section)

Isha988 commented 1 year ago

@anmode I want to work on this issue.

anmode commented 1 year ago

I assigned you but @Isha988 would you like to work on refactoring first?? please till that time the PR i listed would be completed

Isha988 commented 1 year ago

I assigned you but @Isha988 would you like to work on refactoring first?? please till that time the PR i listed would be completed

Okay, no problem I will work on refactoring first. Just brief me about your expectations and exactly work you want to get done in refactoring.

Isha988 commented 1 year ago

One question is this issue and uniformity pr same?

anmode commented 1 year ago

Yess if these issue complete then yess. Otherwise this will a alone issue of making homepage.. and actually it is simple as I provided the code too :).

anmode commented 1 year ago

I assigned you but @Isha988 would you like to work on refactoring first?? please till that time the PR i listed would be completed

Okay, no problem I will work on refactoring first. Just brief me about your expectations and exactly work you want to get done in refactoring.

so refactoring firstly.. if you see there are same code used.

  1. You can make button components or button Folder it should contains all types of button which are there and can be used.
  2. A example we have used alert library as you know.. but i think it good to have alert component and it can be used anywhere. ( In our UI design)
  3. The card you created in registration component can be placed in basic folder as card can be used anywhere like wise you can create issue for refactoring and can start working! if need more clarity. I am up for meet thanks

may be u interested: https://github.com/anmode/grabtern-frontend/issues/316

anmode commented 1 year ago
- components/
  - Layout/
    - Header/
      - Header.js
      - Header.module.css
      - ...
    - Footer/
      - Footer.js
      - Footer.module.css
      - ...
    - ...
  - UI/
    - Button/
      - Button.js
      - Button.module.css
      - ...
    - Input/
      - Input.js
      - Input.module.css
      - ...
    - ...
Isha988 commented 1 year ago

I assigned you but @Isha988 would you like to work on refactoring first?? please till that time the PR i listed would be completed

Okay, no problem I will work on refactoring first. Just brief me about your expectations and exactly work you want to get done in refactoring.

so refactoring firstly.. if you see there are same code used.

  1. You can make button components or button Folder it should contains all types of button which are there and can be used.
  2. A example we have used alert library as you know.. but i think it good to have alert component and it can be used anywhere. ( In our UI design)
  3. The card you created in registration component can be placed in basic folder as card can be used anywhere like wise you can create issue for refactoring and can start working! if need more clarity. I am up for meet thanks

may be u interested: #316

Okay, got it

Isha988 commented 1 year ago
- components/
  - Layout/
    - Header/
      - Header.js
      - Header.module.css
      - ...
    - Footer/
      - Footer.js
      - Footer.module.css
      - ...
    - ...
  - UI/
    - Button/
      - Button.js
      - Button.module.css
      - ...
    - Input/
      - Input.js
      - Input.module.css
      - ...
    - ...

One Question, Should I create component according to new theme or the current theme?

anmode commented 1 year ago

I did not get!... woh astro wali theme copy kr rhe h ..structure nii and current structure ko refactor kr rhe with that new theme.