Closed anmode closed 1 year ago
This PR: https://github.com/anmode/grabtern-frontend/pull/328 ( hero section) This PR:https://github.com/anmode/grabtern-frontend/pull/372 ( Nav) This pR: https://github.com/anmode/grabtern-frontend/issues/403 ( testimonial section)
@anmode I want to work on this issue.
I assigned you but @Isha988 would you like to work on refactoring first?? please till that time the PR i listed would be completed
I assigned you but @Isha988 would you like to work on refactoring first?? please till that time the PR i listed would be completed
Okay, no problem I will work on refactoring first. Just brief me about your expectations and exactly work you want to get done in refactoring.
One question is this issue and uniformity pr same?
Yess if these issue complete then yess. Otherwise this will a alone issue of making homepage.. and actually it is simple as I provided the code too :).
I assigned you but @Isha988 would you like to work on refactoring first?? please till that time the PR i listed would be completed
Okay, no problem I will work on refactoring first. Just brief me about your expectations and exactly work you want to get done in refactoring.
so refactoring firstly.. if you see there are same code used.
may be u interested: https://github.com/anmode/grabtern-frontend/issues/316
- components/
- Layout/
- Header/
- Header.js
- Header.module.css
- ...
- Footer/
- Footer.js
- Footer.module.css
- ...
- ...
- UI/
- Button/
- Button.js
- Button.module.css
- ...
- Input/
- Input.js
- Input.module.css
- ...
- ...
I assigned you but @Isha988 would you like to work on refactoring first?? please till that time the PR i listed would be completed
Okay, no problem I will work on refactoring first. Just brief me about your expectations and exactly work you want to get done in refactoring.
so refactoring firstly.. if you see there are same code used.
- You can make button components or button Folder it should contains all types of button which are there and can be used.
- A example we have used alert library as you know.. but i think it good to have alert component and it can be used anywhere. ( In our UI design)
- The card you created in registration component can be placed in basic folder as card can be used anywhere like wise you can create issue for refactoring and can start working! if need more clarity. I am up for meet thanks
may be u interested: #316
Okay, got it
- components/ - Layout/ - Header/ - Header.js - Header.module.css - ... - Footer/ - Footer.js - Footer.module.css - ... - ... - UI/ - Button/ - Button.js - Button.module.css - ... - Input/ - Input.js - Input.module.css - ... - ...
One Question, Should I create component according to new theme or the current theme?
I did not get!... woh astro wali theme copy kr rhe h ..structure nii and current structure ko refactor kr rhe with that new theme.
Is your feature request related to a problem ? Please describe. ✍️
We will be moving to the new HomePage... new theme is: https://grabtern-new-frontend.vercel.app/ ( light theme)
source code you can take help : https://github.com/anmode/grabtern-NewFrontend ( tailwind classes are there you can copy directly) Our theme color new is
#845ec2
Remember background should not be pure white* See the new themeDescribe briefly how you would implement this enhancement.
Additional context or screenshots
Additional context
Are you contributing for a program?
GSSoC2023
Code of Conduct