search

anmode / grabtern-frontend

Connecting the mentors and creating a network
https://grabtern.in/
MIT License
27 stars 49 forks source link

🚀 [Feature Request] - Optimize Image cropper and reduce image while uploading #496

Closed anmode closed 1 year ago

anmode commented 1 year ago

Is your feature request related to a problem ? Please describe. ✍️

Optimization in Mentor Form... To have image cropper. We have image cropper. /component/basic/imageCropper.js

Describe briefly how you would implement this enhancement.

Optimization....and use it, actually as of now we are not using it.

Additional context or screenshots

No response

Are you contributing for a program?

GSSoC2023

Code of Conduct

MAXASSASSINS commented 1 year ago

Hey, @anmode can you please assign this issue to me?

I have added the image cropper component. Below is the video demonstrating the same.

https://github.com/anmode/grabtern-frontend/assets/97503316/f41e3318-e0c1-4603-9a88-270e3e95e2ca

anmode commented 1 year ago

cool! please try to compress the image too before uploading on cloudinary and also it is taking time too... please see this PR to keeping in mind you can code- https://github.com/anmode/grabtern-frontend/pull/485

anmode commented 1 year ago

btw what you showed in demo is responsive too isn't?

MAXASSASSINS commented 1 year ago

Yes, it is responsive @anmode. When I created the image cropper component I already took care of this.

https://github.com/anmode/grabtern-frontend/assets/97503316/50f04fd4-2099-4d00-a4ae-8d989a430480

MAXASSASSINS commented 1 year ago

As far as image size is concerned we have already compressed the image size by cropping it. I have checked the blob size after cropping it is coming out to be 63 which is very low.

MAXASSASSINS commented 1 year ago

Hey @anmode I have added the upload to Cloudinary functionality. I have checked the execution of the upload function it is taking around 1 sec. Should I create a PR now?

anmode commented 1 year ago

yeah sure please create PR