Feat: Displayed important errors

anmode / grabtern-frontend

Connecting the mentors and creating a network

https://grabtern.in/

MIT License

22 stars 35 forks source link

Feat: Displayed important errors #803

Closed rishuraj1 closed 10 months ago

rishuraj1 commented 10 months ago

Related Issue

Closes: #783

Description of Changes

handled/displayed errors via toast popups

Checklist:

[x] My code adheres to the established style guidelines of this project.
[x] I have conducted a self-review of my code.
[x] I have included comments in areas that may be difficult to understand.
[x] I have made corresponding updates to the project documentation.
[x] My changes have not introduced any new warnings.

Screenshots

Please provide any necessary screenshots to illustrate the changes made.

vercel[bot] commented 10 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
grabtern-frontend	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 3, 2023 2:48pm

github-actions[bot] commented 10 months ago

Thank you, @rishuraj1, for creating this pull request and contributing to GitHub-ReadMe! Our review team will thoroughly review the pull request and will reach out to you soon! Please make sure you have marked all the completed tasks as done. We appreciate your patience and contribution!

rishuraj1 commented 10 months ago

@anmode okay yes I get the idea, also I have done that in login, registration form...

anmode commented 10 months ago

@anmode okay yes I get the idea, also I have done that in login, registration form...

cool, but i see you show sucess message but that's not needed....as user got acknowlegde as state changed so there is no need to show a sucess message

rishuraj1 commented 10 months ago

@anmode ok, I will remove those success notifications and just focus on errors generating while filling form, or performing some other API related work and if there is an error, will show the notification to the user err message

anmode commented 10 months ago

@anmode ok, I will remove those success notifications and just focus on errors generating while filling form, or performing some other API related work and if there is an error, will show the notification to the user err message

yeah! we will show success messsage where they are really required as "while session booking"

anmode commented 10 months ago

@rishuraj1, please be mindful not to perform a force push. Force pushing results in the loss of the entire commit history, and I won't be able to retrieve your previous changes either.

rishuraj1 commented 10 months ago

@anmode yeah, I discarded my commits purposely because there were many conflicts and I wanted to start fresh...😅